Skip to content

Conversation

@pecameron
Copy link
Contributor

bug 1740264
https://bugzilla.redhat.com/show_bug.cgi?id=1740264

SDN-503 Dockerfiles: verify that packages are installed
https://jira.coreos.com/browse/SDN-503

Signed-off-by: Phil Cameron [email protected]

@openshift-ci-robot
Copy link

@pecameron: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

Dockerfiles: verify that packages are installed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 12, 2019
@pecameron pecameron changed the title Dockerfiles: verify that packages are installed Bug 1740264: Dockerfiles: verify that packages are installed Aug 12, 2019
@pecameron
Copy link
Contributor Author

pecameron commented Aug 12, 2019

@sdodson @smarterclayton PTAL
backport of openshift/sdn#21

@sdodson
Copy link
Member

sdodson commented Aug 12, 2019

/approve

If this weren't a backport I'd say we should wait for openshift/images#11 to be picked into release-4.1 instead. Once that's done can you make sure to clean this up?

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2019
@pecameron
Copy link
Contributor Author

@sdodson look at https://jira.coreos.com/browse/SDN-503
This fix is in a lot of places.

@pecameron
Copy link
Contributor Author

@sdodson It appears that openvswitch2.11 (fast datapath) is missing in the 4.1 build. Could you take a look?

@sdodson
Copy link
Member

sdodson commented Aug 12, 2019

@sdodson It appears that openvswitch2.11 (fast datapath) is missing in the 4.1 build. Could you take a look?

There's no openvswitch2.11 package in the datapath repo for 4.1 like there is 4.2. I don't know which SRE team this openshift/release#4572 refers to, but that would be the team to check with I guess.

@pecameron
Copy link
Contributor Author

@sdodson @smarterclayton @squeed What steps does it take to fix the 4.1 sdn build? At present 4.1 sdn will not work. We need to get openvswitch2.11 into the build. Who handles this? Who should I talk to?

@pecameron
Copy link
Contributor Author

/retest

@pecameron
Copy link
Contributor Author

@sdodson @smarterclayton Is this PR ready to merge?

@sdodson
Copy link
Member

sdodson commented Aug 14, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 14, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pecameron, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pecameron
Copy link
Contributor Author

@sdodson Can this be merged?

@sdodson
Copy link
Member

sdodson commented Aug 14, 2019

/retitle Bug 1740264: Dockerfiles: verify package installation

@openshift-ci-robot openshift-ci-robot changed the title Bug 1740264: Dockerfiles: verify that packages are installed Bug 1740264: Dockerfiles: verify that package installation Aug 14, 2019
@sdodson sdodson changed the title Bug 1740264: Dockerfiles: verify that package installation Bug 1740264: Dockerfiles: verify package installation Aug 14, 2019
@sdodson
Copy link
Member

sdodson commented Aug 14, 2019

/bugzilla refresh
Also requires patch manager approval I believe.
/assign @derekwaynecarr

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 14, 2019
@openshift-ci-robot
Copy link

@sdodson: This pull request references a valid Bugzilla bug. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/bugzilla refresh
Also requires patch manager approval I believe.
/assign @derekwaynecarr

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eparis eparis added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 20, 2019
@eparis
Copy link
Member

eparis commented Aug 20, 2019

This does not have a 4.2 bug associated. But since this is entirely internal and not customer facing, I'm letting it through.

@openshift-merge-robot openshift-merge-robot merged commit e33c459 into openshift:release-4.1 Aug 20, 2019
@openshift-ci-robot
Copy link

@pecameron: All pull requests linked via external trackers have merged. Bugzilla bug 1740264 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1740264: Dockerfiles: verify package installation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pecameron pecameron deleted the sdn503 branch August 22, 2019 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants