Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cluster up: remove obsolete asset config properties #18191

Merged
merged 1 commit into from
Jan 25, 2018
Merged

cluster up: remove obsolete asset config properties #18191

merged 1 commit into from
Jan 25, 2018

Conversation

spadgett
Copy link
Member

Follow on to #18114
Requires openshift/origin-web-console-server#20

/assign @deads2k
@jwforres @sdodson FYI
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 19, 2018
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 19, 2018
@spadgett spadgett mentioned this pull request Jan 19, 2018
Merged
@spadgett
Copy link
Member Author

This will need a new tag after openshift/origin-web-console-server#20 merges. The origin-web-console:v3.9.0-alpha.3 image won't have the API changes, so the cluster up extended tests with no --version flag will fail.

@smarterclayton FYI

@jim-minter jim-minter removed their request for review January 19, 2018 17:07
@spadgett spadgett force-pushed the cluster-up-remove-old-asset-config branch from 203306a to 296729c Compare January 23, 2018 23:33
@spadgett
Copy link
Member Author

/retest

@spadgett
Copy link
Member Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 24, 2018
@spadgett
Copy link
Member Author

@deads2k PTAL, this should be able to go in now.

@deads2k
Copy link
Contributor

deads2k commented Jan 24, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, spadgett

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 24, 2018
@spadgett
Copy link
Member Author

flake #16273
/test cmd

@spadgett
Copy link
Member Author

https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/18191/test_pull_request_origin_extended_conformance_gce/14575/

flake #17901

/retest

@spadgett
Copy link
Member Author

FAILURE: PROVISION TEST CLUSTER

/retest

@spadgett
Copy link
Member Author

/retest

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-ci-robot
Copy link

@spadgett: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_conformance_gce 203306a link /test extended_conformance_gce
ci/openshift-jenkins/extended_conformance_install 296729c link /test extended_conformance_install

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 18191, 18264, 18235, 18251, 18271).

@openshift-merge-robot openshift-merge-robot merged commit d5f454d into openshift:master Jan 25, 2018
@spadgett spadgett deleted the cluster-up-remove-old-asset-config branch January 25, 2018 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csrwng csrwng Awaiting requested review from csrwng

@dcbw dcbw Awaiting requested review from dcbw

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spadgett @deads2k @openshift-ci-robot @openshift-merge-robot