Skip to content

Commit

Permalink
cluster up: remove obsolete asset config properties
Browse files Browse the repository at this point in the history
  • Loading branch information
spadgett committed Jan 19, 2018
1 parent 0f43934 commit 203306a
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 83 deletions.
27 changes: 4 additions & 23 deletions install/origin-web-console/console-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,10 @@ clusterInfo:
logoutPublicURL: ""
masterPublicURL: https://127.0.0.1:8443
metricsPublicURL: ""
# TODO: The new extensions properties cannot be set until
# origin-web-console-server has been updated with the API changes since
# `extensions` in the old asset config was an array.
#extensions:
# scriptURLs: []
# stylesheetURLs: []
# properties: null
extensions:
scriptURLs: []
stylesheetURLs: []
properties: null
features:
inactivityTimeoutMinutes: 0
servingInfo:
Expand All @@ -24,19 +21,3 @@ servingInfo:
maxRequestsInFlight: 0
namedCertificates: null
requestTimeoutSeconds: 0

# START deprecated properties
# These properties have been renamed and will be removed from the install
# in a future pull. Keep both the old and new properties for now so that
# the install is not broken while the origin-web-console image is updated.
extensionDevelopment: false
extensionProperties: null
extensionScripts: null
extensionStylesheets: null
extensions: null
loggingPublicURL: ""
logoutURL: ""
masterPublicURL: https://127.0.0.1:8443
metricsPublicURL: ""
publicURL: https://127.0.0.1:8443/console/
# END deprecated properties
27 changes: 4 additions & 23 deletions pkg/oc/bootstrap/bindata.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 0 additions & 14 deletions pkg/oc/bootstrap/docker/openshift/webconsole.go
Original file line number Diff line number Diff line change
Expand Up @@ -73,20 +73,6 @@ func (h *Helper) InstallWebConsole(f *clientcmd.Factory, imageFormat string, ser
clusterInfo["metricsPublicURL"] = metricsURL
}

// START deprecated properties
// These properties have been renamed and will be removed from cluster up
// in a future pull. Keep both the old and new properties for now so that
// the cluster up is not broken while the origin-web-console image is updated.
consoleConfig["publicURL"] = publicURL
consoleConfig["masterPublicURL"] = masterURL
if len(loggingURL) > 0 {
consoleConfig["loggingPublicURL"] = loggingURL
}
if len(metricsURL) > 0 {
consoleConfig["metricsPublicURL"] = metricsURL
}
// END deprecated properties

// serialize it back out as a string to use as a template parameter
updatedConfig, err := yaml.Marshal(consoleConfig)
if err != nil {
Expand Down
27 changes: 4 additions & 23 deletions test/extended/testdata/bindata.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 203306a

Please sign in to comment.