Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

origin.spec: add openshift-diagnostics #18145

Conversation

sosiouxme
Copy link
Member

@sosiouxme sosiouxme commented Jan 17, 2018

One method of fixing #18141 -- add the binary into the origin RPM so it gets into the images.

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sosiouxme
We suggest the following additional approver: eparis

Assign the PR to them by writing /assign @eparis in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 17, 2018
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 17, 2018

@sosiouxme: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_networking_minimal b55c922 link /test extended_networking_minimal
ci/openshift-jenkins/extended_conformance_gce b55c922 link /test extended_conformance_gce
ci/openshift-jenkins/end_to_end b55c922 link /test end_to_end
ci/openshift-jenkins/extended_conformance_install b55c922 link /test extended_conformance_install

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sosiouxme sosiouxme requested review from eparis and deads2k and removed request for soltysh and smarterclayton January 17, 2018 21:25
@sosiouxme sosiouxme added kind/bug Categorizes issue or PR as related to a bug. kind/delivery-blocker labels Jan 18, 2018
@sosiouxme
Copy link
Member Author

Prefer to add sub-command(s) instead of packaging this binary.

@sosiouxme sosiouxme closed this Jan 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/delivery-blocker size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants