openshift-diagnostics binary missing from origin images

[sosiouxme]

oc adm diagnostics DiagnosticPod|NetworkCheck are broken because there is no diagnostics binary to run in the origin-deployer image as expected.

Version

3.9

Steps To Reproduce

1. oc adm diagnostics DiagnosticPod -l 0
2. oc get events

Current Result

[Note] Running diagnostic: DiagnosticPod
       Description: Create a pod to run diagnostics from the application standpoint
       
debug: Created diagnostic pod named pod-diagnostic-test-mdvxv running image openshift/origin-deployer:v3.9.0-alpha.1.
debug: Could not get diagnostic pod logs (loop 1): (*errors.StatusError[2]) container "pod-diagnostics" in pod "pod-diagnostic-test-mdvxv" is waiting to start: ContainerCreating
debug: Could not get diagnostic pod logs (loop 2): (*errors.StatusError[2]) container "pod-diagnostics" in pod "pod-diagnostic-test-mdvxv" is waiting to start: ContainerCreating
debug: Could not get diagnostic pod logs (loop 3): (*errors.StatusError[2]) container "pod-diagnostics" in pod "pod-diagnostic-test-mdvxv" is waiting to start: ContainerCreating
debug: Could not get diagnostic pod logs (loop 4): (*errors.StatusError[2]) container "pod-diagnostics" in pod "pod-diagnostic-test-mdvxv" is waiting to start: ContainerCreating
debug: Could not get diagnostic pod logs (loop 5): (*errors.StatusError[2]) container "pod-diagnostics" in pod "pod-diagnostic-test-mdvxv" is waiting to start: ContainerCreating

Info:  Output from the diagnostic pod (image openshift/origin-deployer:v3.9.0-alpha.1):
       failed to open log file "/var/log/pods/aa2960c7-fbac-11e7-8c56-ae8f67055c4c/pod-diagnostics_0.log": open /var/log/pods/aa2960c7-fbac-11e7-8c56-ae8f67055c4c/pod-diagnostics_0.log: no such file or directory

LAST SEEN   FIRST SEEN   COUNT     NAME                                         KIND      SUBOBJECT                          TYPE      REASON                  SOURCE               MESSAGE
23s         23s          1         pod-diagnostic-test-mdvxv.150aa962da4ca100   Pod                                          Normal    Scheduled               default-scheduler    Successfully assigned pod-diagnostic-test-mdvxv to localhost
23s         23s          1         pod-diagnostic-test-mdvxv.150aa962e3d63280   Pod                                          Normal    SuccessfulMountVolume   kubelet, localhost   MountVolume.SetUp succeeded for volume "default-token-hzq6s" 
22s         22s          1         pod-diagnostic-test-mdvxv.150aa9630a71599f   Pod       spec.containers{pod-diagnostics}   Normal    Pulled                  kubelet, localhost   Container image "openshift/origin-deployer:v3.9.0-alpha.1" already present on machine
22s         22s          1         pod-diagnostic-test-mdvxv.150aa9631390fafb   Pod       spec.containers{pod-diagnostics}   Normal    Created                 kubelet, localhost   Created container
22s         22s          1         pod-diagnostic-test-mdvxv.150aa9631fbd562d   Pod       spec.containers{pod-diagnostics}   Warning   Failed                  kubelet, localhost   Error: failed to start container "pod-diagnostics": executable not found in $PATH

Additional Information

For the 1.8 kubernetes rebase in origin 3.8 openshift infra diagnostics was factored out of the openshift binary for various reasons and is now built as a separate binary openshift-diagnostics. I think we can either just add that binary into the image or add the openshift-diagnostics command into the client and package it as a symlink (as we've done for various commands before).

Of course this needs to be done for OCP as well.