use new crio socket path via constant

[bparees]

No description provided.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these OWNERS Files:

• pkg/build/OWNERS [bparees]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[bparees]

@mrunalp @runcom ptal.

[bparees]

@deads2k @derekwaynecarr fyi.

[bparees]

/test crio

[runcom]

LGTM

[bparees]

/retest

[openshift-merge-robot]

Automatic merge from submit-queue (batch tested with PRs 17734, 17550, 17647, 17761, 17564).

[smarterclayton]

Please stop taking constant dependencies from controllers onto components that should not be required for controllers.

[bparees]

Please stop taking constant dependencies from controllers onto components that should not be required for controllers.

The crio team changed the value of this path between releases and we weren't using the constant and broke. Making us carry our own copy of the value is fragile.

[deads2k]

The crio team changed the value of this path between releases and we weren't using the constant and broke. Making us carry our own copy of the value is fragile.

Doing this creates a diamond dependency problem between controllers and kubelet that ends up left as debt for someone doing a rebase to try to sort out. Someone unfamiliar with the code then has to decide how to reconcile competing levels of a fast moving dependency. If you were actually speaking to cadvisor or interacted with it, this diamond is worth resolving. If you aren't, incurring that debt seems questionable.

Even with this dependency you introduced, changing a constant value will still produce problems at runtime since you're trying to match constant values across components which are allows (and expected) to skew.

[smarterclayton]

Remember, this constant is an API. You can't change this across deployments without a corresponding change on both sides (i.e. they have to expose two sockets at old and new locations to allow the control plane to migrate). So this is their problem for now.

…

On Fri, Dec 15, 2017 at 3:36 PM, David Eads ***@***.***> wrote: The crio team changed the value of this path between releases and we weren't using the constant and broke. Making us carry our own copy of the value is fragile. Doing this creates a diamond dependency problem between controllers and kubelet that ends up left as debt for someone doing a rebase to try to sort out. Someone unfamiliar with the code then has to decide how to reconcile competing levels of a fast moving dependency. If you were actually speaking to cadvisor or interacted with it, this diamond is worth resolving. If you aren't, incurring that debt seems questionable. Even with this dependency you introduced, changing a constant value will still produce problems at runtime since you're trying to match constant values across components which are allows (and expected) to skew. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#17761 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABG_p6tjI6a__U5netO1Yl6aGUizmBw8ks5tAthFgaJpZM4RBKUc> .