Skip to content

crio: change socket path to /var/run/crio/crio.sock#6449

Merged
sdodson merged 1 commit into
openshift:masterfrom
giuseppe:crio-change-socket-path
Dec 14, 2017
Merged

crio: change socket path to /var/run/crio/crio.sock#6449
sdodson merged 1 commit into
openshift:masterfrom
giuseppe:crio-change-socket-path

Conversation

@giuseppe
Copy link
Copy Markdown
Member

@giuseppe giuseppe commented Dec 12, 2017

it is required for OpenShift 3.9

Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com

@giuseppe
crio: change socket path to /var/run/crio/crio.sock
646dac7 
it is required for OpenShift 3.9

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@giuseppe giuseppe requested a review from runcom December 12, 2017 19:07
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 12, 2017
@runcom
Copy link
Copy Markdown
Member

runcom commented Dec 12, 2017

looks good

mrunalp
mrunalp approved these changes Dec 12, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@mrunalp mrunalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@runcom
Copy link
Copy Markdown
Member

runcom commented Dec 12, 2017

This is failing because the system container is CRI-O v1.8.x (v3.8). We need openshift-eng/aos-cd-jobs#901 in order to use the new >1.8.x system container

@sdodson
Copy link
Copy Markdown
Member

sdodson commented Dec 13, 2017

/test crio

@sdodson
Copy link
Copy Markdown
Member

sdodson commented Dec 13, 2017

Pushed an updated test job, lets see if it produces expected results.

@sdodson
Copy link
Copy Markdown
Member

sdodson commented Dec 13, 2017

/test install

@sdodson
Copy link
Copy Markdown
Member

sdodson commented Dec 13, 2017

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 13, 2017
@runcom
Copy link
Copy Markdown
Member

runcom commented Dec 13, 2017

alright, it's grabbing the 3.9 image now, but my grep-foo is flaky so I need to fix that. Plus, there are some not-expected failures in tests

@runcom
Copy link
Copy Markdown
Member

runcom commented Dec 13, 2017

so, build tests are failing, I'm not sure why actually /cc @mrunalp @bparees

@bparees
Copy link
Copy Markdown
Contributor

bparees commented Dec 13, 2017

seems likely you need openshift/origin#17761

@runcom
Copy link
Copy Markdown
Member

runcom commented Dec 13, 2017

@bparees awesome, thanks

This PR LGTM then

@runcom runcom mentioned this pull request Dec 13, 2017
Merged
mrunalp
mrunalp approved these changes Dec 13, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@mrunalp mrunalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Dec 13, 2017

@giuseppe: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_conformance_install_crio 646dac7 link /test crio
ci/openshift-jenkins/install 646dac7 link /test install

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mrunalp
Copy link
Copy Markdown
Member

mrunalp commented Dec 13, 2017

@sdodson The crio test need the PR that @bparees has on origin to pass. Chicken and egg so we can let this one in with the crio failures.

@sdodson sdodson merged commit 3355314 into openshift:master Dec 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@mrunalp mrunalp mrunalp approved these changes

@runcom runcom runcom approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sdodson sdodson

Labels

lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@giuseppe @runcom @sdodson @bparees @openshift-ci-robot @mrunalp