Skip to content

run the run policy test serially #16262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 1 commit into from
Sep 10, 2017
Merged

run the run policy test serially #16262

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion test/extended/builds/run_policy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ import (
exutil "github.com/openshift/origin/test/extended/util"
)

var _ = g.Describe("[builds][Slow] using build configuration runPolicy", func() {
// this test is very latency sensitive so run it by itself (serially).
var _ = g.Describe("[builds][Slow][Serial] using build configuration runPolicy", func() {
Copy link
Contributor

@csrwng csrwng Sep 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you're already making this change, might as well get rid of the assignment to var _. I don't see the need for that.

Copy link
Contributor Author

@bparees bparees Sep 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm. it's what we do in all our extended tests(not just the builds ones), I assumed it served some initialization purpose/magic.

Copy link
Contributor Author

@bparees bparees Sep 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"The var _ = ... trick allows us to evaluate the Describe at the top level without having to wrap it in a func init() {}"

(from https://onsi.github.io/ginkgo/)

Copy link
Contributor

@csrwng csrwng Sep 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh, true you don't need an init. Thx.

defer g.GinkgoRecover()
var (
// Use invalid source here as we don't care about the result
Expand Down