run the run policy test serially #16262
Conversation
openshift-ci-robot
added
the
size/XS
openshift-merge-robot
added
the
approved
|
|
||
| var _ = g.Describe("[builds][Slow] using build configuration runPolicy", func() { | ||
| // this test is very latency sensitive so run it by itself (serially). | ||
| var _ = g.Describe("[builds][Slow][Serial] using build configuration runPolicy", func() { |
There was a problem hiding this comment.
Since you're already making this change, might as well get rid of the assignment to var _. I don't see the need for that.
There was a problem hiding this comment.
hm. it's what we do in all our extended tests(not just the builds ones), I assumed it served some initialization purpose/magic.
There was a problem hiding this comment.
"The var _ = ... trick allows us to evaluate the Describe at the top level without having to wrap it in a func init() {}"
There was a problem hiding this comment.
ahh, true you don't need an init. Thx.
|
/lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees, csrwng The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
|
Automatic merge from submit-queue |
8 participants
No description provided.