Skip to content

[release-4.9] OCPBUGS-4948: Fix label key truncation for subscription annotations (#2731) #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Dec 19, 2022
Merged

[release-4.9] OCPBUGS-4948: Fix label key truncation for subscription annotations (#2731) #423

openshift-merge-robot merged 1 commit into from
Dec 19, 2022

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Dec 15, 2022

This is an automated cherry-pick of #421

/assign grokspawn

@perdasilva
Fix label key truncation for subscription annotations (#2731)
7d9b9e6 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>

Co-authored-by: Per Goncalves da Silva <pegoncal@redhat.com>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: 1bdf969e6dff317e975de21078d60dd1406235e0
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 15, 2022
Merged
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 15, 2022

@openshift-cherrypick-robot: Jira Issue OCPBUGS-4799 has been cloned as Jira Issue OCPBUGS-4948. Retitling PR to link against new bug.
/retitle [release-4.9] OCPBUGS-4948: Fix label key truncation for subscription annotations (#2731)

Details

In response to this:

This is an automated cherry-pick of #421

/assign grokspawn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.9] OCPBUGS-4799: Fix label key truncation for subscription annotations (#2731) [release-4.9] OCPBUGS-4948: Fix label key truncation for subscription annotations (#2731) Dec 15, 2022
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 15, 2022
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 15, 2022

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-4948, which is invalid:

  • expected dependent Jira Issue OCPBUGS-4799 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #421

/assign grokspawn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 15, 2022

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.9] OCPBUGS-4948: Fix label key truncation for subscription annotations (#2731)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@grokspawn
Copy link
Contributor

grokspawn commented Dec 15, 2022

/retest-required

@jianzhangbjz
Copy link
Member

jianzhangbjz commented Dec 16, 2022

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 16, 2022
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 16, 2022

@jianzhangbjz: This pull request references Jira Issue OCPBUGS-4948, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.9.z) matches configured target version for branch (4.9.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-4799 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-4799 targets the "4.10.z" version, which is one of the valid target versions: 4.10.0, 4.10.z
  • bug has dependents

Requesting review from QA contact:
/cc @jianzhangbjz

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from jianzhangbjz December 16, 2022 00:17
@jianzhangbjz
Copy link
Member

jianzhangbjz commented Dec 16, 2022

Test passed, details: https://issues.redhat.com/browse/OCPBUGS-4948
/label cherry-pick-approved
/label qe-approved

@openshift-ci openshift-ci bot added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. qe-approved Signifies that QE has signed off on this PR labels Dec 16, 2022
@oceanc80
Copy link
Contributor

oceanc80 commented Dec 16, 2022

/label backport-risk-assessed
/lgtm

@oceanc80
Copy link
Contributor

oceanc80 commented Dec 16, 2022

/retest-required

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Dec 16, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 16, 2022

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ankitathomas
Copy link
Contributor

ankitathomas commented Dec 19, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ankitathomas, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 19, 2022
@openshift-merge-robot openshift-merge-robot merged commit 10727ea into openshift:release-4.9 Dec 19, 2022
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 19, 2022

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-4948 has been moved to the MODIFIED state.

Details

In response to this:

This is an automated cherry-pick of #421

/assign grokspawn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@awgreene
Copy link
Contributor

awgreene commented Jan 10, 2023

/cherry-pick release-4.8

@openshift-cherrypick-robot
Copy link
Author

openshift-cherrypick-robot commented Jan 10, 2023

@awgreene: new pull request created: #427

Details

In response to this:

/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 10, 2023
Merged
grokspawn pushed a commit to grokspawn/operator-framework-olm that referenced this pull request Jul 15, 2025
@camilamacedo86 @grokspawn
add go version check to protect us from accidentally upgraded (opensh…
7f1c3dd 
…ift#423)

Upstream-repository: api
Upstream-commit: 322568fc9f4b838268f45bfbdcdc9ca8dbd508c7
grokspawn pushed a commit to grokspawn/operator-framework-olm that referenced this pull request Jul 15, 2025
@camilamacedo86 @grokspawn
add go version check to protect us from accidentally upgraded (opensh…
9faafe6 
…ift#423)

Upstream-repository: api
Upstream-commit: 322568fc9f4b838268f45bfbdcdc9ca8dbd508c7
grokspawn pushed a commit to grokspawn/operator-framework-olm that referenced this pull request Jul 15, 2025
@camilamacedo86 @grokspawn
add go version check to protect us from accidentally upgraded (opensh…
a3de53d 
…ift#423)

Upstream-repository: api
Upstream-commit: 322568fc9f4b838268f45bfbdcdc9ca8dbd508c7
grokspawn pushed a commit to grokspawn/operator-framework-olm that referenced this pull request Jul 16, 2025
@camilamacedo86 @grokspawn
add go version check to protect us from accidentally upgraded (opensh…
757c901 
…ift#423)

Upstream-repository: api
Upstream-commit: 322568fc9f4b838268f45bfbdcdc9ca8dbd508c7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benluddy benluddy Awaiting requested review from benluddy

@dinhxuanvu dinhxuanvu Awaiting requested review from dinhxuanvu

@jianzhangbjz jianzhangbjz Awaiting requested review from jianzhangbjz

Assignees

@bandrade bandrade

@oceanc80 oceanc80

@jianzhangbjz jianzhangbjz

@kuiwang02 kuiwang02

@Xia-Zhao-rh Xia-Zhao-rh

@grokspawn grokspawn

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.