Skip to content

OCPBUGS-4799: Fix label key truncation for subscription annotations (#2731) #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Dec 15, 2022
Merged

OCPBUGS-4799: Fix label key truncation for subscription annotations (#2731) #421

openshift-merge-robot merged 1 commit into from
Dec 15, 2022

Conversation

@grokspawn
Copy link
Contributor

@grokspawn grokspawn commented Dec 13, 2022

Signed-off-by: Per Goncalves da Silva pegoncal@redhat.com

Co-authored-by: Per Goncalves da Silva pegoncal@redhat.com
Upstream-repository: operator-lifecycle-manager
Upstream-commit: 1bdf969e6dff317e975de21078d60dd1406235e0

@perdasilva @grokspawn
Fix label key truncation for subscription annotations (#2731)
bc42fb7 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>

Co-authored-by: Per Goncalves da Silva <pegoncal@redhat.com>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: 1bdf969e6dff317e975de21078d60dd1406235e0
@openshift-ci-robot openshift-ci-robot added the jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. label Dec 13, 2022
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 13, 2022

@grokspawn: This pull request references Jira Issue OCPBUGS-4799, which is invalid:

  • expected dependent Jira Issue OCPBUGS-4797 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Signed-off-by: Per Goncalves da Silva pegoncal@redhat.com

Co-authored-by: Per Goncalves da Silva pegoncal@redhat.com
Upstream-repository: operator-lifecycle-manager
Upstream-commit: 1bdf969e6dff317e975de21078d60dd1406235e0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Dec 13, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 13, 2022

@grokspawn: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

OCPBUGS-4799: Fix label key truncation for subscription annotations (#2731)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from anik120 and dinhxuanvu December 13, 2022 18:41
@oceanc80
Copy link
Contributor

oceanc80 commented Dec 13, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 13, 2022
@grokspawn
Copy link
Contributor Author

grokspawn commented Dec 13, 2022

/cherry-pick release-4.9

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Dec 13, 2022

@grokspawn: once the present PR merges, I will cherry-pick it on top of release-4.9 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jianzhangbjz
Copy link
Member

jianzhangbjz commented Dec 14, 2022

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 14, 2022
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 14, 2022

@jianzhangbjz: This pull request references Jira Issue OCPBUGS-4799, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.10.z) matches configured target version for branch (4.10.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-4797 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-4797 targets the "4.11.z" version, which is one of the valid target versions: 4.11.0, 4.11.z
  • bug has dependents

Requesting review from QA contact:
/cc @jianzhangbjz

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from jianzhangbjz December 14, 2022 02:59
@grokspawn
Copy link
Contributor Author

grokspawn commented Dec 14, 2022

/retest-required

@jianzhangbjz
Copy link
Member

jianzhangbjz commented Dec 14, 2022

/cherry-pick-approved
/lgtm

@jianzhangbjz
Copy link
Member

jianzhangbjz commented Dec 14, 2022

/approve

@jianzhangbjz
Copy link
Member

jianzhangbjz commented Dec 14, 2022

/label backport-risk-assessed

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 14, 2022

@jianzhangbjz: Can not set label backport-risk-assessed: Must be member in one of these teams: [openshift-patch-managers]

Details

In response to this:

/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@oceanc80
Copy link
Contributor

oceanc80 commented Dec 14, 2022

/retest-required

@perdasilva
Copy link
Contributor

perdasilva commented Dec 14, 2022

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Dec 14, 2022
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2022
@grokspawn
Copy link
Contributor Author

grokspawn commented Dec 14, 2022

/retest-required

bandrade
bandrade approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@bandrade bandrade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label cherry-pick-approved

@openshift-ci openshift-ci bot added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 14, 2022
@jianzhangbjz
Copy link
Member

jianzhangbjz commented Dec 15, 2022

I guess it needs the /approve label.
/assign @gallettilance @perdasilva @grokspawn

@jianzhangbjz
Copy link
Member

jianzhangbjz commented Dec 15, 2022

/approve

1 similar comment
@oceanc80
Copy link
Contributor

oceanc80 commented Dec 15, 2022

/approve

@perdasilva
Copy link
Contributor

perdasilva commented Dec 15, 2022

/label approved

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 15, 2022

@perdasilva: Can not set label approved: Must be member in one of these teams: [openshift-release-oversight]

Details

In response to this:

/label approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@perdasilva
Copy link
Contributor

perdasilva commented Dec 15, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 15, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bandrade, grokspawn, jianzhangbjz, oceanc80, perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2022
@grokspawn
Copy link
Contributor Author

grokspawn commented Dec 15, 2022

/retest-required

@grokspawn
Copy link
Contributor Author

grokspawn commented Dec 15, 2022

I guess it needs the /approve label. /assign @gallettilance @perdasilva @grokspawn

It was strange that it retracted the approved label once Bruno applied the cherry-pick-approved label. Is that intentional?

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 15, 2022

@grokspawn: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit ca59a21 into openshift:release-4.10 Dec 15, 2022
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 15, 2022

@grokspawn: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-4799 has been moved to the MODIFIED state.

Details

In response to this:

Signed-off-by: Per Goncalves da Silva pegoncal@redhat.com

Co-authored-by: Per Goncalves da Silva pegoncal@redhat.com
Upstream-repository: operator-lifecycle-manager
Upstream-commit: 1bdf969e6dff317e975de21078d60dd1406235e0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Dec 15, 2022

@grokspawn: new pull request created: #423

Details

In response to this:

/cherry-pick release-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 15, 2022
Merged
@grokspawn grokspawn deleted the release-4.10 branch December 15, 2022 16:57
tmshort pushed a commit to tmshort/operator-framework-olm that referenced this pull request Apr 30, 2025
@grokspawn @tmshort
make grpcPodConfig.extractContent.cacheDir an optional field (openshi…
afb5615 
…ft#421)

Upstream-repository: api
Upstream-commit: 436783bec2efadaeb51864c212923f8e226d21a3
@tmshort tmshort mentioned this pull request Apr 30, 2025
Merged
tmshort pushed a commit to tmshort/operator-framework-olm that referenced this pull request Apr 30, 2025
@grokspawn @tmshort
make grpcPodConfig.extractContent.cacheDir an optional field (openshi…
f82e3bf 
…ft#421)

Upstream-repository: api
Upstream-commit: 436783bec2efadaeb51864c212923f8e226d21a3
tmshort pushed a commit to tmshort/operator-framework-olm that referenced this pull request Apr 30, 2025
@grokspawn @tmshort
make grpcPodConfig.extractContent.cacheDir an optional field (openshi…
9be65a7 
…ft#421)

Upstream-repository: api
Upstream-commit: 436783bec2efadaeb51864c212923f8e226d21a3
tmshort pushed a commit to tmshort/operator-framework-olm that referenced this pull request Apr 30, 2025
@grokspawn @tmshort
make grpcPodConfig.extractContent.cacheDir an optional field (openshi…
2df3c68 
…ft#421)

Upstream-repository: api
Upstream-commit: 436783bec2efadaeb51864c212923f8e226d21a3
grokspawn added a commit to grokspawn/operator-framework-olm that referenced this pull request Jun 11, 2025
@grokspawn
make grpcPodConfig.extractContent.cacheDir an optional field (openshi…
c17157c 
…ft#421)

Upstream-repository: api
Upstream-commit: 436783bec2efadaeb51864c212923f8e226d21a3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anik120 anik120 Awaiting requested review from anik120

@dinhxuanvu dinhxuanvu Awaiting requested review from dinhxuanvu

@jianzhangbjz jianzhangbjz Awaiting requested review from jianzhangbjz

1 more reviewer

@bandrade bandrade bandrade approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bandrade bandrade

@perdasilva perdasilva

@oceanc80 oceanc80

@jianzhangbjz jianzhangbjz

@gallettilance gallettilance

@kuiwang02 kuiwang02

@Xia-Zhao-rh Xia-Zhao-rh

@grokspawn grokspawn

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.