NE-2447: Implement inspect_route tool#147
Conversation
|
@bentito: This pull request references NE-2447 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bentito The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| @@ -15,16 +15,6 @@ import ( | |||
| "sigs.k8s.io/controller-runtime/pkg/client/fake" | |||
| ) | |||
There was a problem hiding this comment.
could we do grouping via testify/suite ?
e.g. similar to requested here: #131 (comment) ?
I guess we can also do that in a follow up PR, for all netedge tests.
pkg/toolsets/netedge/routes.go
Outdated
| { | ||
| Tool: api.Tool{ | ||
| Name: "inspect_route", | ||
| Description: "Inspect an OpenShift Route to view its configuration, status, and related services.", |
There was a problem hiding this comment.
looks like the actual implementation only returns the Route , not "related services".
Perhaps something like:
"Inspect an OpenShift Route to view its full configuration and status."
|
/retest |
|
@bentito: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This PR adds the inspect_route tool to the NetEdge toolset, enabling LLMs to analyze OpenShift Route configurations.
This tool is essential for the NetEdge diagnostic capabilities as it allows the agent to verify:
By exposing these details, the agent can troubleshoot connectivity issues at the ingress layer.