Skip to content

OCPBUGS-31697: Added user-managed LB note to nw-configuring-route-tim… #93206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dfitzmau merged 1 commit into from
Jun 30, 2025
Merged

OCPBUGS-31697: Added user-managed LB note to nw-configuring-route-tim… #93206

dfitzmau merged 1 commit into from
Jun 30, 2025

Conversation

@dfitzmau
Copy link
Contributor

@dfitzmau dfitzmau commented May 12, 2025 •
edited
Loading

Version(s):
4.12+

Issue:
OCPBUGS-31697

Link to docs preview:

  • SME has approved this change (Andrey Lebedev).
  • QE has approved this change (Hongan Li).

Add. resources:

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 12, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 12, 2025

@dfitzmau: This pull request references Jira Issue OCPBUGS-31697, which is invalid:

  • expected the bug to target the "4.20.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

…eouts.adoc

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 12, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented May 12, 2025 •
edited
Loading

🤖 Mon Jun 30 08:45:07 - Prow CI generated the docs preview:

https://93206--ocpdocs-pr.netlify.app/openshift-dedicated/latest/networking/routes/route-configuration.html
https://93206--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/configuring_ingress_cluster_traffic/configuring-ingress-cluster-traffic-aws.html
https://93206--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/routes/route-configuration.html
https://93206--ocpdocs-pr.netlify.app/openshift-rosa/latest/networking/routes/route-configuration.html

@dfitzmau dfitzmau requested a review from Copilot May 12, 2025 12:59
Copilot AI reviewed May 12, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the route timeout documentation to include an IMPORTANT note for users who configure a user-managed load balancer. The changes include a new note block to warn about configuring the load balancer’s timeout values, as well as minor formatting improvements.

  • Added an IMPORTANT note advising that the load balancer’s timeout must exceed the route service’s timeout to prevent congestion.
  • Improved overall text formatting for clarity.

lihongan
lihongan reviewed May 13, 2025
View reviewed changes
@lihongan
Copy link

lihongan commented May 13, 2025

Just one comment, the rest looks good. Thanks

@xenolinux xenolinux added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels May 26, 2025
xenolinux
xenolinux reviewed May 26, 2025
View reviewed changes
Copy link
Contributor

@xenolinux xenolinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xenolinux xenolinux added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels May 26, 2025
@bergerhoffer
Copy link
Contributor

bergerhoffer commented Jun 16, 2025

The branch/enterprise-4.20 label has been added to this PR.

This is because your PR targets the main branch and is labeled for enterprise-4.19. And any PR going into main must also target the latest version branch (enterprise-4.20).

If the update in your PR does NOT apply to version 4.20 onward, please re-target this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main.

@candita
Copy link

candita commented Jun 27, 2025

Sorry @dfitzmau and @alebedev87 we assigned this in a meeting and I forgot to update the PR.

/assign @alebedev87

alebedev87
alebedev87 reviewed Jun 27, 2025
View reviewed changes
Copy link
Contributor

@alebedev87 alebedev87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a small remark.

@openshift-ci
Copy link

openshift-ci bot commented Jun 30, 2025

@dfitzmau: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dfitzmau dfitzmau merged commit 6724a19 into openshift:main Jun 30, 2025
2 checks passed
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 30, 2025

@dfitzmau: Jira Issue OCPBUGS-31697: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-31697 has been moved to the MODIFIED state.

Details

In response to this:

Version(s):
4.12+

Issue:
OCPBUGS-31697

Link to docs preview:

  • SME has approved this change (Andrey Lebedev).
  • QE has approved this change (Hongan Li).

Add. resources:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dfitzmau
Copy link
Contributor Author

dfitzmau commented Jun 30, 2025

/cherrypick enterprise-4.20

@dfitzmau
Copy link
Contributor Author

dfitzmau commented Jun 30, 2025

/cherrypick enterprise-4.19

@dfitzmau
Copy link
Contributor Author

dfitzmau commented Jun 30, 2025

/cherrypick enterprise-4.18

@dfitzmau
Copy link
Contributor Author

dfitzmau commented Jun 30, 2025

/cherrypick enterprise-4.17

@dfitzmau
Copy link
Contributor Author

dfitzmau commented Jun 30, 2025

/cherrypick enterprise-4.16

@dfitzmau
Copy link
Contributor Author

dfitzmau commented Jun 30, 2025

/cherrypick enterprise-4.15

@dfitzmau
Copy link
Contributor Author

dfitzmau commented Jun 30, 2025

/cherrypick enterprise-4.14

@dfitzmau
Copy link
Contributor Author

dfitzmau commented Jun 30, 2025

/cherrypick enterprise-4.13

@dfitzmau
Copy link
Contributor Author

dfitzmau commented Jun 30, 2025

/cherrypick enterprise-4.12

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jun 30, 2025

@dfitzmau: new pull request created: #95414

Details

In response to this:

/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 30, 2025
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jun 30, 2025

@dfitzmau: new pull request created: #95415

Details

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 30, 2025
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jun 30, 2025

@dfitzmau: new pull request created: #95416

Details

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 30, 2025
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jun 30, 2025

@dfitzmau: new pull request created: #95417

Details

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 30, 2025
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jun 30, 2025

@dfitzmau: new pull request created: #95418

Details

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 30, 2025
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jun 30, 2025

@dfitzmau: new pull request created: #95419

Details

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 30, 2025
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jun 30, 2025

@dfitzmau: new pull request created: #95420

Details

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 30, 2025
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jun 30, 2025

@dfitzmau: new pull request created: #95421

Details

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 30, 2025
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jun 30, 2025

@dfitzmau: new pull request created: #95422

Details

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xenolinux xenolinux xenolinux left review comments

Copilot code review Copilot Copilot left review comments

+2 more reviewers

@alebedev87 alebedev87 alebedev87 left review comments

@lihongan lihongan lihongan left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@alebedev87 alebedev87

Labels

branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 branch/enterprise-4.20 jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@dfitzmau @openshift-ci-robot @ocpdocs-previewbot @lihongan @bergerhoffer @candita @openshift-cherrypick-robot @alebedev87 @xenolinux