Skip to content

OSDOCS-5074: Choosing subnets when creating a LoadBalancerService ingress Controller #85350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kcarmichael08 merged 1 commit into from
Jan 6, 2025
Merged

OSDOCS-5074: Choosing subnets when creating a LoadBalancerService ingress Controller #85350

kcarmichael08 merged 1 commit into from
Jan 6, 2025

Conversation

@DCChadwick
Copy link

@DCChadwick DCChadwick commented Nov 22, 2024 •
edited
Loading

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 22, 2024 •
edited by openshift-ci bot
Loading

@DCChadwick: This pull request references OSDOCS-5074 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

Details

In response to this:

…ss controller

Version(s): 4.17+

Issue: OSDOCS-5074

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 22, 2024
@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 22, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Nov 22, 2024 •
edited
Loading

🤖 Mon Jan 06 19:53:44 - Prow CI generated the docs preview:

https://85350--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/configuring_ingress_cluster_traffic/configuring-ingress-cluster-traffic-aws.html

gcs278
gcs278 reviewed Nov 25, 2024
View reviewed changes
Copy link

@gcs278 gcs278 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start for discussion, I've made some suggestions just to direct you in the right path, so we can keep iterating. Let me know if they make sense.

I think this module belongs on this page: https://docs.openshift.com/container-platform/4.16/networking/configuring_ingress_cluster_traffic/configuring-ingress-cluster-traffic-aws.html
with a new section called:

Configuring Load Balancer Subnets for IngressControllers on AWS

Then within this section, you have two procedures:

  1. Create IngressController with Subnets
  2. Update IngressController with Subnets

I think that keeps it mostly consistent with the other procedures in that page. But let me know if you think differently. Thanks!

@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 9, 2024
@DCChadwick
Copy link
Author

DCChadwick commented Dec 12, 2024

@lihongan - This PR is ready for QE review.

lihongan
lihongan reviewed Dec 13, 2024
View reviewed changes
lihongan
lihongan reviewed Dec 13, 2024
View reviewed changes
lihongan
lihongan reviewed Dec 13, 2024
View reviewed changes
lihongan
lihongan reviewed Dec 13, 2024
View reviewed changes
gcs278
gcs278 reviewed Dec 13, 2024
View reviewed changes
gcs278
gcs278 reviewed Dec 13, 2024
View reviewed changes
gcs278
gcs278 reviewed Dec 13, 2024
View reviewed changes
@DCChadwick DCChadwick force-pushed the osdocs5074 branch 2 times, most recently from 854dc6a to 4c349e2 Compare December 19, 2024 18:52
@DCChadwick
Copy link
Author

DCChadwick commented Dec 19, 2024

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Dec 19, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 19, 2024 •
edited by openshift-ci bot
Loading

@DCChadwick: This pull request references OSDOCS-5074 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

Details

In response to this:

…ss controller

Version(s): 4.17+

Issue: OSDOCS-5074

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@skrthomas skrthomas added merge-review-in-progress Signifies that the merge review team is reviewing this PR branch/enterprise-4.17 branch/enterprise-4.18 and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Dec 19, 2024
@jeana-redhat jeana-redhat added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Dec 20, 2024
jeana-redhat
jeana-redhat reviewed Dec 20, 2024
View reviewed changes
Copy link
Contributor

@jeana-redhat jeana-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some formatting issues here (most comments are along similar lines). Please reach out if you need help or clarification on anything, and I am happy to rereview when it's ready since I'm familiar :)

/remove-label merge-review-in-progress
/remove-label merge-review-needed

@openshift-ci openshift-ci bot removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels Dec 20, 2024
@DCChadwick DCChadwick force-pushed the osdocs5074 branch 2 times, most recently from 8be6da6 to 38c8911 Compare December 20, 2024 21:16
gcs278
gcs278 reviewed Dec 20, 2024
View reviewed changes
Copy link

@gcs278 gcs278 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates! Mainly minor details now.

@DCChadwick DCChadwick force-pushed the osdocs5074 branch 2 times, most recently from e8b3545 to 088d82c Compare January 6, 2025 15:23
@DCChadwick
Copy link
Author

DCChadwick commented Jan 6, 2025

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jan 6, 2025
@kcarmichael08 kcarmichael08 added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Jan 6, 2025
kcarmichael08
kcarmichael08 reviewed Jan 6, 2025
View reviewed changes
Copy link
Contributor

@kcarmichael08 kcarmichael08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple of things that need to be fixed before it is merged; otherwise, LGTM!

gcs278
gcs278 reviewed Jan 6, 2025
View reviewed changes
@openshift-ci
Copy link

openshift-ci bot commented Jan 6, 2025

@DCChadwick: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kcarmichael08 kcarmichael08 merged commit ceacc5e into openshift:main Jan 6, 2025
2 checks passed
@kcarmichael08
Copy link
Contributor

kcarmichael08 commented Jan 6, 2025

/cherrypick enterprise-4.17

@kcarmichael08
Copy link
Contributor

kcarmichael08 commented Jan 6, 2025

/cherrypick enterprise-4.18

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jan 6, 2025

@kcarmichael08: new pull request created: #86737

Details

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 6, 2025
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jan 6, 2025

@kcarmichael08: new pull request created: #86738

Details

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 6, 2025
Merged
@kcarmichael08 kcarmichael08 removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Jan 6, 2025
@dfitzmau dfitzmau mentioned this pull request May 12, 2025
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeana-redhat jeana-redhat jeana-redhat left review comments

@skrthomas skrthomas skrthomas left review comments

@kcarmichael08 kcarmichael08 kcarmichael08 left review comments

+4 more reviewers

@gcs278 gcs278 gcs278 left review comments

@lihongan lihongan lihongan left review comments

@GroceryBoyJr GroceryBoyJr GroceryBoyJr left review comments

@ocpdocs-vale-bot ocpdocs-vale-bot ocpdocs-vale-bot left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

branch/enterprise-4.17 branch/enterprise-4.18 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.