Skip to content

Conversation

@wgabor0427
Copy link
Contributor

@wgabor0427 wgabor0427 commented Aug 22, 2024

Version(s):
4.14+

Issue::
https://issues.redhat.com/browse/OCPBUGS-15814

Link to docs preview:
https://80835--ocpdocs-pr.netlify.app/

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 22, 2024
@openshift-ci
Copy link

openshift-ci bot commented Aug 22, 2024

Hi @wgabor0427. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kalexand-rh
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 26, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Aug 26, 2024

🤖 Fri Aug 30 16:25:59 - Prow CI generated the docs preview:
https://80835--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

@wgabor0427
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Aug 29, 2024
@dfitzmau
Copy link
Contributor

/remove-label peer-review-needed

/label peer-review-in-progress

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Aug 29, 2024
@dfitzmau
Copy link
Contributor

Hi @wgabor0427 . Jianping is correct. The file is added as an include in the following assemblies:

  • cco-mode-gcp-workload-identity.adoc
  • cco-mode-sts.adoc

But, it the include is not found:

Screenshot from 2024-08-29 14-51-51

Meaning: That these files are no longer in use:

Screenshot from 2024-08-29 14-54-35

@dfitzmau
Copy link
Contributor

dfitzmau commented Aug 29, 2024

This PR can be closed as it looks like to me the 4.14+ doc does not exist. However, 4.13 and 4.12 are correct. Example from 4.13 doc.

Screenshot from 2024-08-29 14-57-13

@wgabor0427 wgabor0427 closed this Aug 29, 2024
@wgabor0427
Copy link
Contributor Author

This work is no longer relevant for 4.14+

@jianping-shu
Copy link

In my understanding, it doesn't mean that this work won't be applicable for 4.14+, instead you may need to modify a different source file to update the links I pasted above.

@openshift-ci
Copy link

openshift-ci bot commented Aug 30, 2024

@wgabor0427: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@wgabor0427
Copy link
Contributor Author

/label merge-review-needed

Updated step #4 in the "Incorporating the Cloud Credential Operator utility manifests" section to match what was in PRs #80833 and #80830. Modified the cco-ccoctl-install-creating-manifests.adoc file.

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Sep 3, 2024
@bscott-rh bscott-rh self-assigned this Sep 3, 2024
@bscott-rh bscott-rh removed the merge-review-needed Signifies that the merge review team needs to review this PR label Sep 3, 2024
@bscott-rh
Copy link
Contributor

@jianping-shu Bill has updated the PR and it looks like the changes are showing up in the installation assemblies correctly. Can you please verify? Thank you

Copy link
Contributor

@bscott-rh bscott-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated changes LGTM from peer review perspective.

@bscott-rh bscott-rh removed the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Sep 3, 2024
@jianping-shu
Copy link

LGTM

@bscott-rh bscott-rh added the merge-review-needed Signifies that the merge review team needs to review this PR label Sep 5, 2024
@adellape adellape self-assigned this Sep 5, 2024
@adellape adellape added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Sep 5, 2024
@adellape adellape merged commit 66bab8b into openshift:main Sep 5, 2024
@adellape
Copy link
Contributor

adellape commented Sep 5, 2024

/cherrypick enterprise-4.17

@adellape
Copy link
Contributor

adellape commented Sep 5, 2024

/cherrypick enterprise-4.16

@adellape
Copy link
Contributor

adellape commented Sep 5, 2024

/cherrypick enterprise-4.15

@adellape
Copy link
Contributor

adellape commented Sep 5, 2024

/cherrypick enterprise-4.14

@openshift-cherrypick-robot

@adellape: new pull request created: #81398

Details

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@adellape: new pull request created: #81399

Details

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@adellape: new pull request created: #81400

Details

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@adellape: new pull request created: #81401

Details

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 branch/enterprise-4.17 merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR ok-to-test Indicates a non-member PR verified by an org member that is safe to test. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants