-
Notifications
You must be signed in to change notification settings - Fork 1.9k
OCPBUGS-15814 Updated step 5 in the Running the Installation section #80835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @wgabor0427. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
🤖 Fri Aug 30 16:25:59 - Prow CI generated the docs preview: |
|
I didn't see the update take effect in the following preview. Maybe it is because the chapters reworked in 4.14+. Pls. have a check |
|
/label peer-review-needed |
|
/remove-label peer-review-needed /label peer-review-in-progress |
|
Hi @wgabor0427 . Jianping is correct. The file is added as an include in the following assemblies:
But, it the include is not found: Meaning: That these files are no longer in use: |
|
This PR can be closed as it looks like to me the 4.14+ doc does not exist. However, 4.13 and 4.12 are correct. Example from 4.13 doc. |
|
This work is no longer relevant for 4.14+ |
|
In my understanding, it doesn't mean that this work won't be applicable for 4.14+, instead you may need to modify a different source file to update the links I pasted above. |
0c14901 to
23289a7
Compare
23289a7 to
5f3f47a
Compare
|
@wgabor0427: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@jianping-shu Bill has updated the PR and it looks like the changes are showing up in the installation assemblies correctly. Can you please verify? Thank you |
bscott-rh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated changes LGTM from peer review perspective.
|
LGTM |
|
/cherrypick enterprise-4.17 |
|
/cherrypick enterprise-4.16 |
|
/cherrypick enterprise-4.15 |
|
/cherrypick enterprise-4.14 |
|
@adellape: new pull request created: #81398 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@adellape: new pull request created: #81399 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@adellape: new pull request created: #81400 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@adellape: new pull request created: #81401 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |



Version(s):
4.14+
Issue::
https://issues.redhat.com/browse/OCPBUGS-15814
Link to docs preview:
https://80835--ocpdocs-pr.netlify.app/
QE review:
Additional information: