-
Notifications
You must be signed in to change notification settings - Fork 1.9k
OCBUGS-15814_413 Updated step 5 in the Runnning the Installation section #80833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @wgabor0427. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
@wgabor0427: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/label peer-review-needed |
|
/remove-label peer-review-needed /label peer-review-in-progress |
dfitzmau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @wgabor0427 .
Please update the Description section of your PR to include the following links:
* [Running the installer-GCP](https://80833--ocpdocs-pr.netlify.app/openshift-enterprise/latest/authentication/managing_cloud_provider_credentials/cco-mode-gcp-workload-identity.html#sts-mode-installing-manual-run-installer_cco-mode-gcp-workload-identity)
* [Running the installer-AWS](https://80833--ocpdocs-pr.netlify.app/openshift-enterprise/latest/authentication/managing_cloud_provider_credentials/cco-mode-sts.html#sts-mode-installing-manual-run-installer_cco-mode-sts)
/remove-label peer-review-in-progress
/label peer-review-done
| ---- | ||
|
|
||
| . Copy the private key that the `ccoctl` generated in the `tls` directory to the installation directory: | ||
| . Copy the `tls` directory containing the private key that the `ccoctl` generated to the installation directory: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| . Copy the `tls` directory containing the private key that the `ccoctl` generated to the installation directory: | |
| . Copy the `tls` directory that contains the private key to the installation directory: |
I think the previous command should explain ccoctl's part in the process.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. Like the rewrite
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
|
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
|
@openshift-bot: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Version(s):
4.13
Issue:
https://issues.redhat.com/browse/OCPBUGS-15814
Link to docs preview:
QE review:
Additional information: