-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Distributed tracing and Red Hat build of OpenTelemetry 3.1 release #72079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🤖 Mon Feb 26 16:51:47 - Prow CI generated the docs preview: https://72079--ocpdocs-pr.netlify.app |
df38c5e to
adf3012
Compare
|
/label peer-review-done |
|
/label merge-review-needed |
|
@max-cx, there's no way to tell what has and has not been changed in the diffs. Is there a particular reason why you're putting an aggregate PR up instead of the original, smaller PRs? If we reviewed this, it would be a larger burden on the review squad. |
|
@kalexand-rh, yes, I aggregated the PRs because
Unfortunately, this is a consequence of content reorganization. I made it as user-friendly as possible to review by first having it reviewed as separate smaller PRs and then linking to the preview pages of the specific new content in the PR description. |
81afe87 to
e9e8fc6
Compare
kcarmichael08
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First batch of comments
kcarmichael08
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you go through and make sure that all of your xrefs contain Anchor IDs? They will work on docs.openshift.com usually without this, but I think they can break the customer portal or not work in certain situations if they don't have this.
distr_tracing/distr_tracing_arch/distr-tracing-architecture.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
next batch of comments (above)
41e8869 to
dfbe120
Compare
kcarmichael08
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you've already fixed some of these - if so, please ignore
kalexand-rh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When this passes merge review, it can be merged.
|
Good to merge when finishes building. |
|
@max-cx: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/cherrypick enterprise-4.12 |
|
@kcarmichael08: #72079 failed to apply on top of branch "enterprise-4.12": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick enterprise-4.13 |
|
/cherrypick enterprise-4.14 |
|
/cherrypick enterprise-4.15 |
|
@kcarmichael08: #72079 failed to apply on top of branch "enterprise-4.13": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@kcarmichael08: #72079 failed to apply on top of branch "enterprise-4.14": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@kcarmichael08: new pull request created: #72118 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
💡 Please note that the
XXLsize of this PR is misleading: content from many pages was collected into fewer pages (the pages with the release notes for past releases), and several sections were migrated into separate pages (OpenTelemetry). So this shows up like a lot of new content in the diffs, which is in fact not the case.#70943
#71565
#69962
#71074
Version(s):
4.12, 4.13, 4.14, 4.15, 4.16
Manual cherry-picks to OCP 4.12, 4.13, 4.14:
#72123
#72127
#72128
Issue:
https://issues.redhat.com/browse/OBSDOCS-764
https://issues.redhat.com/browse/OBSDOCS-790
https://issues.redhat.com/browse/OBSDOCS-811
https://issues.redhat.com/browse/TRACING-3574
https://issues.redhat.com/browse/TRACING-3802
Link to docs preview:
New content:
https://72079--ocpdocs-pr.netlify.app/openshift-enterprise/latest/distr_tracing/distr_tracing_rn/distr-tracing-rn-3-1
https://72079--ocpdocs-pr.netlify.app/openshift-enterprise/latest/otel/otel_rn/otel-rn-3.1
https://72079--ocpdocs-pr.netlify.app/openshift-enterprise/latest/distr_tracing/distr_tracing_tempo/distr-tracing-tempo-configuring#span-red-metrics-and-alerting-rules
https://72079--ocpdocs-pr.netlify.app/openshift-enterprise/latest/otel/otel-configuration-of-otel-collector#otel-config-target-allocator_otel-configuration-of-otel-collector
Reorganized content:
https://72079--ocpdocs-pr.netlify.app/openshift-enterprise/latest/distr_tracing/distr_tracing_rn/distr-tracing-rn-past-releases
https://72079--ocpdocs-pr.netlify.app/openshift-enterprise/latest/otel/otel_rn/otel-rn-past-releases
https://72079--ocpdocs-pr.netlify.app/openshift-enterprise/latest/otel/otel-configuration-of-otel-collector
https://72079--ocpdocs-pr.netlify.app/openshift-enterprise/latest/otel/otel-configuration-of-instrumentation
https://72079--ocpdocs-pr.netlify.app/openshift-enterprise/latest/otel/otel-sending-traces-and-metrics-to-otel-collector
https://72079--ocpdocs-pr.netlify.app/openshift-enterprise/latest/otel/otel-config-send-metrics-monitoring-stack
https://72079--ocpdocs-pr.netlify.app/openshift-enterprise/latest/otel/otel-forwarding
https://72079--ocpdocs-pr.netlify.app/openshift-enterprise/latest/otel/otel-configuring-otelcol-metrics
https://72079--ocpdocs-pr.netlify.app/openshift-enterprise/latest/otel/otel-config-multicluster
QE review:
Additional information: