Skip to content

OBSDOCS-790: Reorganize OTEL content #71565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
max-cx wants to merge 1 commit into from
Closed

OBSDOCS-790: Reorganize OTEL content #71565

max-cx wants to merge 1 commit into from

Conversation

@max-cx
Copy link
Contributor

@max-cx max-cx commented Feb 13, 2024 •
edited
Loading

Version(s):

4.12, 4.13, 4.14, 4.15, 4.16

Issue:

https://issues.redhat.com/browse/OBSDOCS-790
https://issues.redhat.com/browse/OBSDOCS-811

Link to docs preview:

💡 Please note that the XL size of this PR is misleading: Because this PR only reorganizes the existing, currently published content across files and TOC menu levels, there is no need to review any of the docs content. What can be reviewed is the following:

New arrangement of OTEL content in terms of pages and table of contents:
image
https://71565--ocpdocs-pr.netlify.app/openshift-enterprise/latest/otel/otel-installing

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 13, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 13, 2024 •
edited by openshift-ci bot
Loading

@max-cx: This pull request references OBSDOCS-790 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

Details

In response to this:

  • add additional resources
  • OBSDOCS-790: Move sections around

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 13, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 13, 2024 •
edited by openshift-ci bot
Loading

@max-cx: This pull request references OBSDOCS-790 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

Details

In response to this:

  • add additional resources
  • OBSDOCS-790: Move sections around

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link

openshift-ci bot commented Feb 13, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 13, 2024
@max-cx
Copy link
Contributor Author

max-cx commented Feb 13, 2024

/test all

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Feb 13, 2024 •
edited
Loading

🤖 Thu Feb 22 16:53:55 - Prow CI generated the docs preview: https://71565--ocpdocs-pr.netlify.app

@max-cx max-cx force-pushed the OBSDOCS-790 branch 3 times, most recently from 97986f5 to 141d92d Compare February 13, 2024 21:49
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 13, 2024 •
edited by openshift-ci bot
Loading

@max-cx: This pull request references OBSDOCS-790 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

Details

In response to this:

Version(s):

Issue:

https://issues.redhat.com//browse/OBSDOCS-790
https://issues.redhat.com/browse/OBSDOCS-811

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@max-cx
Copy link
Contributor Author

max-cx commented Feb 14, 2024

/test all

@max-cx
Copy link
Contributor Author

max-cx commented Feb 14, 2024

/test all

@max-cx max-cx force-pushed the OBSDOCS-790 branch 2 times, most recently from c03373f to c55bde9 Compare February 14, 2024 23:17
@openshift-ci openshift-ci bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 14, 2024
@max-cx
Copy link
Contributor Author

max-cx commented Feb 14, 2024

/test all

@max-cx
Copy link
Contributor Author

max-cx commented Feb 15, 2024

/test all

@max-cx
Copy link
Contributor Author

max-cx commented Feb 15, 2024

/test all

@max-cx
Copy link
Contributor Author

max-cx commented Feb 15, 2024

/test all

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 15, 2024 •
edited by openshift-ci bot
Loading

@max-cx: This pull request references OBSDOCS-790 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

Details

In response to this:

Version(s):

Issue:

https://issues.redhat.com//browse/OBSDOCS-790
https://issues.redhat.com/browse/OBSDOCS-811

Link to docs preview:

image
https://71565--ocpdocs-pr.netlify.app/openshift-enterprise/latest/otel/otel-installing

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 15, 2024 •
edited by openshift-ci bot
Loading

@max-cx: This pull request references OBSDOCS-790 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

Details

In response to this:

Version(s):

4.12, 4.13, 4.14, 4.15

Issue:

https://issues.redhat.com//browse/OBSDOCS-790
https://issues.redhat.com/browse/OBSDOCS-811

Link to docs preview:

image
https://71565--ocpdocs-pr.netlify.app/openshift-enterprise/latest/otel/otel-installing

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 15, 2024 •
edited by openshift-ci bot
Loading

@max-cx: This pull request references OBSDOCS-790 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

Details

In response to this:

Version(s):

4.12, 4.13, 4.14, 4.15

Issue:

https://issues.redhat.com//browse/OBSDOCS-790
https://issues.redhat.com/browse/OBSDOCS-811

Link to docs preview:

New arrangement of OTEL content in terms of pages and table of contents:
image
https://71565--ocpdocs-pr.netlify.app/openshift-enterprise/latest/otel/otel-installing

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

gwynnemonahan
gwynnemonahan reviewed Feb 20, 2024
View reviewed changes
gwynnemonahan
gwynnemonahan reviewed Feb 20, 2024
View reviewed changes
@gwynnemonahan
Copy link
Contributor

gwynnemonahan commented Feb 20, 2024

Hey @max-cx ,

Nice work! I went back and forth between the current Tempo and OTEL content, and this PR. That is a lot to keep organized! Well done.

I found a couple of small things to consider. I do like the reorganization, and how you've broken out content for sending metrics to the monitoring stack, sending traces and metrics to the Collector, etc. I found that helpful.

I'm still in training, so @abrennan89 also needs to review this.

@abrennan89 abrennan89 self-requested a review February 20, 2024 14:32
@abrennan89 abrennan89 added this to the Continuous Release milestone Feb 20, 2024
@max-cx max-cx mentioned this pull request Feb 20, 2024
Closed
1 task
abrennan89
abrennan89 reviewed Feb 20, 2024
View reviewed changes
Copy link
Contributor

@abrennan89 abrennan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@max-cx initial review done, lmk if you want me to take another look if you implement changes

@abrennan89 abrennan89 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 20, 2024
abrennan89
abrennan89 reviewed Feb 21, 2024
View reviewed changes
Copy link
Contributor

@abrennan89 abrennan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some final / additional comments

@max-cx max-cx force-pushed the OBSDOCS-790 branch 2 times, most recently from 979a125 to 95bbc76 Compare February 22, 2024 15:58
@max-cx
Copy link
Contributor Author

max-cx commented Feb 22, 2024

/retest

@openshift-ci
Copy link

openshift-ci bot commented Feb 22, 2024

@max-cx: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 22, 2024 •
edited by openshift-ci bot
Loading

@max-cx: This pull request references OBSDOCS-790 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

Details

In response to this:

Version(s):

4.12, 4.13, 4.14, 4.15, 4.16

Issue:

https://issues.redhat.com/browse/OBSDOCS-790
https://issues.redhat.com/browse/OBSDOCS-811

Link to docs preview:

💡 Please note that the XL size of this PR is misleading: Because this PR only reorganizes the existing, currently published content across files and TOC menu levels, there is no need to review any of the docs content. What can be reviewed is the following:

New arrangement of OTEL content in terms of pages and table of contents:
image
https://71565--ocpdocs-pr.netlify.app/openshift-enterprise/latest/otel/otel-installing

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@max-cx max-cx mentioned this pull request Feb 22, 2024
Merged
1 task
@max-cx
Copy link
Contributor Author

max-cx commented Feb 22, 2024

Closing this PR because its commit has been cherry-picked into #72079.

@max-cx max-cx closed this Feb 22, 2024
This was referenced Feb 26, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gwynnemonahan gwynnemonahan gwynnemonahan left review comments

@abrennan89 abrennan89 abrennan89 left review comments

+2 more reviewers

@pavolloffay pavolloffay pavolloffay approved these changes

@IshwarKanse IshwarKanse IshwarKanse approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.

7 participants

@max-cx @openshift-ci-robot @ocpdocs-previewbot @gwynnemonahan @pavolloffay @IshwarKanse @abrennan89