Skip to content

Conversation

@bscott-rh
Copy link
Contributor

@bscott-rh bscott-rh commented Mar 13, 2023

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 13, 2023
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Mar 13, 2023

🤖 Updated build preview is available at:
https://57130--docspreview.netlify.app

Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/12475

@bscott-rh
Copy link
Contributor Author

bscott-rh commented Mar 13, 2023

@jianlinliu Hello, please take a look at the documentation update for https://issues.redhat.com/browse/CORS-2520. Thank you

@jianlinliu
Copy link

@sgaoshang pls help review the PR.

@sgaoshang
Copy link

@bscott-rh most lgtm, only that 3 new fields are added in PR, so should we also address bootType here? Also pls refer to https://redhat-internal.slack.com/archives/C0211848DBN/p1678126369498519 for bootType field.

The new fields include:
bootType: optionally indicates the boot type for the worker Machine VM.
project: optionally identifies a Prism project for the Machine's VM.
categories: optionally adds one or more prism categories for the Machine's VM.

@bscott-rh
Copy link
Contributor Author

@bscott-rh most lgtm, only that 3 new fields are added in PR, so should we also address bootType here? Also pls refer to https://redhat-internal.slack.com/archives/C0211848DBN/p1678126369498519 for bootType field.

The new fields include:
bootType: optionally indicates the boot type for the worker Machine VM.
project: optionally identifies a Prism project for the Machine's VM.
categories: optionally adds one or more prism categories for the Machine's VM.

Thanks for catching this, I noted it in Slack but didn't note it in real life :) updated the PR, PTAL. Can you check the Nutanix documentation link that I referenced for bootType and let me know if you know of a better link I can share to explain the boot modes?

@sgaoshang
Copy link

@bscott-rh most lgtm, only that 3 new fields are added in PR, so should we also address bootType here? Also pls refer to https://redhat-internal.slack.com/archives/C0211848DBN/p1678126369498519 for bootType field.

The new fields include:
bootType: optionally indicates the boot type for the worker Machine VM.
project: optionally identifies a Prism project for the Machine's VM.
categories: optionally adds one or more prism categories for the Machine's VM.

Thanks for catching this, I noted it in Slack but didn't note it in real life :) updated the PR, PTAL. Can you check the Nutanix documentation link that I referenced for bootType and let me know if you know of a better link I can share to explain the boot modes?

I did not find a better link maybe 5 Select one of the following firmware to boot the VM in https://portal.nutanix.com/page/documents/details?targetId=AHV-Admin-Guide:wc-vm-create-acropolis-wc-t.html?

Others lgtm, thanks.

@yannickstruyf3
Copy link

LGTM

@bscott-rh
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 28, 2023
@mburke5678 mburke5678 added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Mar 28, 2023
@mburke5678 mburke5678 added peer-review-done Signifies that the peer review team has reviewed this PR branch/enterprise-4.13 and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 28, 2023
@mburke5678 mburke5678 added this to the Planned for 4.13 GA milestone Mar 28, 2023
@mburke5678
Copy link
Contributor

@bscott-rh A few nits. Otherwise LGTM

@bscott-rh
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Mar 29, 2023
@mjpytlak mjpytlak added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Mar 29, 2023
@mjpytlak mjpytlak merged commit 53cc08b into openshift:main Mar 29, 2023
@mjpytlak
Copy link
Contributor

/cherrypick enterprise-4.13

@openshift-cherrypick-robot

@mjpytlak: new pull request created: #57910

Details

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bscott-rh bscott-rh deleted the OSDOCS-5340 branch October 30, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.13 merge-review-in-progress Signifies that the merge review team is reviewing this PR peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants