Skip to content

Support the new fields in NutanixMachineProviderConfig #6841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Feb 28, 2023
Merged

Support the new fields in NutanixMachineProviderConfig #6841

openshift-merge-robot merged 1 commit into from
Feb 28, 2023

Conversation

@yanhua121
Copy link
Contributor

@yanhua121 yanhua121 commented Feb 9, 2023

  • Support the new fields of NutanixMachineProviderConfig added by the api PR Add optional new fields to NutanixMachineProviderConfig api#1390.
  • The new fields include:
    bootType: optionally indicates the boot type for the worker Machine VM.
    project: optionally identifies a Prism project for the Machine's VM.
    categories: optionally adds one or more prism categories for the Machine's VM.

@openshift-ci openshift-ci bot requested review from r4f4 and rvanderp3 February 9, 2023 14:34
rvanderp3
rvanderp3 reviewed Feb 9, 2023
View reviewed changes
@yanhua121 yanhua121 force-pushed the nutanix-machinespec-new-fields branch 2 times, most recently from d70209c to 2135ce0 Compare February 9, 2023 23:40
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 10, 2023
@yanhua121 yanhua121 force-pushed the nutanix-machinespec-new-fields branch from 2135ce0 to 424fc95 Compare February 10, 2023 22:01
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 10, 2023
@yanhua121 yanhua121 force-pushed the nutanix-machinespec-new-fields branch 2 times, most recently from 353a494 to 52f905e Compare February 15, 2023 18:17
@yanhua121
Copy link
Contributor Author

yanhua121 commented Feb 17, 2023

/test e2e-nutanix-ovn

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 17, 2023
@yanhua121 yanhua121 force-pushed the nutanix-machinespec-new-fields branch from 52f905e to 957b435 Compare February 17, 2023 15:31
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 17, 2023
rvanderp3
rvanderp3 reviewed Feb 22, 2023
View reviewed changes
@yanhua121 yanhua121 force-pushed the nutanix-machinespec-new-fields branch from 957b435 to 8147459 Compare February 23, 2023 05:42
@yanhua121
Copy link
Contributor Author

yanhua121 commented Feb 23, 2023

/retest-required

@yanhua121
Copy link
Contributor Author

yanhua121 commented Feb 23, 2023

/test e2e-nutanix-ovn

@rvanderp3
Copy link
Contributor

rvanderp3 commented Feb 23, 2023

/lgtm
/assign @patrickdillon

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 23, 2023
@yanhua121
Copy link
Contributor Author

yanhua121 commented Feb 24, 2023

/test e2e-nutanix-ovn

1 similar comment
@yanhua121
Copy link
Contributor Author

yanhua121 commented Feb 24, 2023

/test e2e-nutanix-ovn

@patrickdillon
Copy link
Contributor

patrickdillon commented Feb 27, 2023

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2023
@patrickdillon
Copy link
Contributor

patrickdillon commented Feb 27, 2023

/skip

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 27, 2023

/retest-required

Remaining retests: 0 against base HEAD 5b4ad0f and 2 for PR HEAD 8147459f8bd164ea62a7810d7e12bfd6aa9cd96d in total

@yanhua121 yanhua121 force-pushed the nutanix-machinespec-new-fields branch from 8147459 to 919c85a Compare February 27, 2023 18:34
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2023
@yanhua121 yanhua121 force-pushed the nutanix-machinespec-new-fields branch from 919c85a to 1c2b448 Compare February 27, 2023 19:08
@rvanderp3
Copy link
Contributor

rvanderp3 commented Feb 28, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 28, 2023 •
edited
Loading

@yanhua121: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-e2e-aws-ovn-upgrade 1c2b448 link false /test okd-e2e-aws-ovn-upgrade
ci/prow/e2e-nutanix-ovn 1c2b448 link false /test e2e-nutanix-ovn
ci/prow/okd-scos-e2e-aws-ovn 1c2b448 link false /test okd-scos-e2e-aws-ovn
ci/prow/okd-scos-e2e-aws-upgrade 1c2b448 link false /test okd-scos-e2e-aws-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 28, 2023

/retest-required

Remaining retests: 0 against base HEAD 41e436e and 2 for PR HEAD 1c2b448 in total

@openshift-merge-robot openshift-merge-robot merged commit 1445b3b into openshift:master Feb 28, 2023
@sgaoshang sgaoshang mentioned this pull request Mar 14, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@r4f4 r4f4 Awaiting requested review from r4f4

1 more reviewer

@rvanderp3 rvanderp3 rvanderp3 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@patrickdillon patrickdillon

@rvanderp3 rvanderp3

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yanhua121 @rvanderp3 @patrickdillon @openshift-ci-robot @openshift-merge-robot