Skip to content

Conversation

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 28, 2022
@johnwilkins
Copy link
Contributor Author

@honza Can you have a look at these changes and give an LGTM if they are okay?

@netlify
Copy link

netlify bot commented Apr 28, 2022

Deploy Preview for osdocs ready!

Name Link
🔨 Latest commit a705c5a
🔍 Latest deploy log https://app.netlify.com/sites/osdocs/deploys/62793deb914b200009598ea5
😎 Deploy Preview https://deploy-preview-45104--osdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@johnwilkins
Copy link
Contributor Author

@pamoedom Can you review this PR and give an LGTM if the changes are okay?

@honza
Copy link
Member

honza commented May 4, 2022

This is blocked by openshift/installer#5787 and openshift/enhancements#1071

…VM when there is no DHCP server on the baremetal network..
@kquinn1204
Copy link
Contributor

LGTM no review comments from me.

@zhouhao3
Copy link
Contributor

LGTM

@honza
Copy link
Member

honza commented Jun 14, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 14, 2022
@abhatt-rh
Copy link
Contributor

LGTM

1 similar comment
@ahardin-rh
Copy link
Contributor

LGTM

@ahardin-rh ahardin-rh added peer-review-done Signifies that the peer review team has reviewed this PR telco Label for all Telco PRs branch/enterprise-4.11 labels Jun 14, 2022
@ahardin-rh ahardin-rh added this to the Future Release milestone Jun 14, 2022
@ahardin-rh ahardin-rh merged commit 7e9daf3 into openshift:main Jun 14, 2022
@ahardin-rh
Copy link
Contributor

/cherrypick enterprise-4.11

@openshift-cherrypick-robot

@ahardin-rh: new pull request created: #46696

Details

In response to this:

/cherrypick enterprise-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.11 lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files. telco Label for all Telco PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants