Skip to content

baremetal: Add bootstrap-external-ip #1071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
May 16, 2022
Merged

baremetal: Add bootstrap-external-ip #1071

openshift-merge-robot merged 1 commit into from
May 16, 2022

Conversation

@honza
Copy link
Member

@honza honza commented Mar 23, 2022

No description provided.

@openshift-ci openshift-ci bot requested review from dustymabe and sdodson March 23, 2022 14:34
sadasu
sadasu reviewed Mar 24, 2022
View reviewed changes
enhancements/baremetal/bootstrap-external-ip.md

We will add a new field to the `install-config.yaml` file called
`bootstrapExternalIP`. This is similar to the existing
`bootstrapProvisioningIP` field.
Copy link
Contributor

@sadasu sadasu Mar 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add additional validations for this new field? If so, what would they be?

Copy link
Contributor

@zhouhao3 zhouhao3 Apr 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just verifying it's in the correct IP format should be fine.

Copy link
Contributor

@hardys hardys May 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should validate similar to other fields e.g

  • IP syntax is valid
  • IP is in the MachineNetwork
  • IP doesn't conflict with other IPs (e.g API/Ingress VIP IPs)

Copy link
Contributor

@sadasu sadasu May 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I was wondering if there is some correlation with the networkConfig field. Since nothing is mentioned in the doc about it, I am assuming that they can occur independently. We could configure bootstrapExternalStaticIP, and
bootstrapExternalGateway irrespective of whether the networkConfig field is used to configure StaticIPs on hosts within the cluster.

zaneb
zaneb reviewed Mar 29, 2022
View reviewed changes
zhouhao3
zhouhao3 reviewed Apr 6, 2022
View reviewed changes
Copy link
Contributor

@zhouhao3 zhouhao3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me.
Is there a track issue for this proposal? I can help with some tasks for the implementation of this proposal if needed.

@elfosardo
Copy link
Contributor

elfosardo commented Apr 11, 2022

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Apr 11, 2022
@honza honza mentioned this pull request May 4, 2022
Merged
hardys
hardys reviewed May 9, 2022
View reviewed changes
hardys
hardys reviewed May 9, 2022
View reviewed changes
enhancements/baremetal/bootstrap-external-ip.md
## Design Details

### Test Plan

Copy link
Contributor

@hardys hardys May 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should follow up and add CI coverage for static IP deployments, I know @derekhiggins was working on that but I'm not sure of the latest status

Copy link

@derekhiggins derekhiggins May 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I stopped rebasing my PR when I saw had pushed a new version of his PR, @imain are you still working on it or will I rebase mine ? openshift-metal3/dev-scripts#1297

hardys
hardys reviewed May 9, 2022
View reviewed changes
@zaneb
Copy link
Member

zaneb commented May 9, 2022

I agree with Steve's suggestion of stating which section of the install-config this will go in. Otherwise LGTM.

zaneb
zaneb reviewed May 9, 2022
View reviewed changes
@honza honza force-pushed the bootstrap-external-ip branch from 2963a7c to 9ab8256 Compare May 9, 2022 17:32
@hardys
Copy link
Contributor

hardys commented May 10, 2022

This version lgtm other than the markdownlint failure.

We should follow up with the test-plan details though when we make progress on getting an e2e job in place that exercises the static-ip scenario (if you have to update this again perhaps mention there is work in-progress to add such coverage, and that this will get tested via that new job when it's done)

@honza honza force-pushed the bootstrap-external-ip branch 2 times, most recently from 29b1a54 to 56f0903 Compare May 11, 2022 12:41
zaneb
zaneb reviewed May 12, 2022
View reviewed changes
Copy link
Member

@zaneb zaneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 12, 2022
@honza honza force-pushed the bootstrap-external-ip branch from 56f0903 to 934c65e Compare May 12, 2022 17:25
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 12, 2022
@dtantsur
Copy link
Member

dtantsur commented May 13, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2022
@zaneb
Copy link
Member

zaneb commented May 13, 2022

/lgtm

@dtantsur
Copy link
Member

dtantsur commented May 16, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 16, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 16, 2022

@honza: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 4f51092 into openshift:master May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zaneb zaneb zaneb left review comments

@dustymabe dustymabe Awaiting requested review from dustymabe

@sdodson sdodson Awaiting requested review from sdodson

+4 more reviewers

@derekhiggins derekhiggins derekhiggins left review comments

@hardys hardys hardys left review comments

@sadasu sadasu sadasu left review comments

@zhouhao3 zhouhao3 zhouhao3 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@dtantsur dtantsur

@zaneb zaneb

@elfosardo elfosardo

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@honza @elfosardo @zaneb @hardys @dtantsur @derekhiggins @sadasu @zhouhao3 @openshift-merge-robot