Skip to content

Conversation

@opayne1
Copy link
Contributor

@opayne1 opayne1 commented Nov 12, 2021

BZ link

  • Applies to main and enterprise-4.9+
  • Preview link (Switching between channels section)

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 12, 2021
@netlify
Copy link

netlify bot commented Nov 12, 2021

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: faff9b5

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/61b798a2fbc1cd00088004a7

😎 Browse the preview: https://deploy-preview-38686--osdocs.netlify.app/openshift-enterprise/latest/updating/understanding-upgrade-channels-release

@opayne1
Copy link
Contributor Author

opayne1 commented Nov 12, 2021

@gpei PTAL. Are these changes still valid? I saw this #22252 (comment) and just want to be sure.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The double quotes behind <channel> is ” , which should be "
If we changed the command from "oc adm upgrade channel" to "oc patch clusterversion", line #137 should also be updated: "through the adm upgrade channel command"

And I could find another two places which is using oc adm upgrade channel command, should we also update them?

Use the web console or oc adm upgrade channel <channel> to change the update channel. You can follow the steps in Updating a cluster within a minor version by using the CLI to complete the update after you change to a 4.9 channel
If you do not want the Cluster Version Operator to fetch available updates from the upgrade recommendation service, you can use the oc adm upgrade channel command in the OpenShift CLI to configure an empty channel

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @jianlinliu for anything I may missed

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prior to 4.9, we can use the patch command to change the channel. With 4.9 and later, we can use oc adm upgrade channel <channel> to change the channel.

We had a discussion in #36015 (comment).

@opayne1 opayne1 changed the title Correcting command to upgrade clusterversion channel BZ2014246: Correcting command to upgrade clusterversion channel Nov 17, 2021
@opayne1 opayne1 force-pushed the BZ2014246 branch 3 times, most recently from af363e6 to 4cff75b Compare November 18, 2021 20:25
@opayne1
Copy link
Contributor Author

opayne1 commented Nov 18, 2021

Could I get your input on this @wking? I know we discussed adm upgrade channel a while back. This is still valid here correct?

@opayne1
Copy link
Contributor Author

opayne1 commented Dec 13, 2021

@shellyyang1989 PTAL. Thank you!

@shellyyang1989
Copy link

lgtm

@lpettyjo lpettyjo added this to the Next Release milestone Dec 14, 2021
@lpettyjo lpettyjo added the peer-review-needed Signifies that the peer review team needs to review this PR label Dec 14, 2021
@lpettyjo lpettyjo self-requested a review December 14, 2021 13:29
Copy link
Contributor

@lpettyjo lpettyjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lpettyjo lpettyjo added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Dec 14, 2021
@lpettyjo lpettyjo merged commit 534dc37 into openshift:main Dec 14, 2021
@lpettyjo
Copy link
Contributor

/cherrypick enterprise-4.10

@lpettyjo
Copy link
Contributor

/cherrypick enterprise-4.9

@openshift-cherrypick-robot

@lpettyjo: new pull request created: #39846

Details

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@lpettyjo: new pull request created: #39847

Details

In response to this:

/cherrypick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.9 branch/enterprise-4.10 peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants