-
Notifications
You must be signed in to change notification settings - Fork 1.9k
BZ2014246: Correcting command to upgrade clusterversion channel #38686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
✔️ Deploy Preview for osdocs ready! 🔨 Explore the source changes: faff9b5 🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/61b798a2fbc1cd00088004a7 😎 Browse the preview: https://deploy-preview-38686--osdocs.netlify.app/openshift-enterprise/latest/updating/understanding-upgrade-channels-release |
|
@gpei PTAL. Are these changes still valid? I saw this #22252 (comment) and just want to be sure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The double quotes behind <channel> is ” , which should be "
If we changed the command from "oc adm upgrade channel" to "oc patch clusterversion", line #137 should also be updated: "through the adm upgrade channel command"
And I could find another two places which is using oc adm upgrade channel command, should we also update them?
Use the web console or oc adm upgrade channel <channel> to change the update channel. You can follow the steps in Updating a cluster within a minor version by using the CLI to complete the update after you change to a 4.9 channel
If you do not want the Cluster Version Operator to fetch available updates from the upgrade recommendation service, you can use the oc adm upgrade channel command in the OpenShift CLI to configure an empty channel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @jianlinliu for anything I may missed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prior to 4.9, we can use the patch command to change the channel. With 4.9 and later, we can use oc adm upgrade channel <channel> to change the channel.
We had a discussion in #36015 (comment).
af363e6 to
4cff75b
Compare
|
Could I get your input on this @wking? I know we discussed |
|
@shellyyang1989 PTAL. Thank you! |
|
lgtm |
lpettyjo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
/cherrypick enterprise-4.10 |
|
/cherrypick enterprise-4.9 |
|
@lpettyjo: new pull request created: #39846 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@lpettyjo: new pull request created: #39847 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
BZ link
mainandenterprise-4.9+