modules/understanding-upgrade-channels: Recommend clearing channel #22252

wking · 2020-05-19T03:59:09Z

I would prefer to configure this by clearing the upstream setting, which seems more intuitive for "there is no upstream" to me. But sadly, it seems that the CVO has been falling back to a default URI when the ClusterVersion upstream is empty since way back, and that this behavior is enshrined in the API. Although the channel docs also talk about defaults, the only channel defaulting in the CVO is when creating a ClusterVersion object after the in-cluster copy was (accidentally?) deleted. So maybe we could talk folks into adjusting the CVO logic to return NoUpstream in the empty-upstream case, but at the moment, clearing the channel is the best approach for "the CVO keeps complaining that it can't hit the upstream, and I want to quiet it down" (rhbz#1827378)5.

wking · 2020-06-08T22:45:40Z

/assign @kalexand-rh

modules/understanding-upgrade-channels.adoc

kalexand-rh

I have a question and some suggestions.

modules/understanding-upgrade-channels.adoc

kalexand-rh · 2020-06-24T23:31:48Z

@jianlinliu, will you PTAL? I think this change should go back to 4.2. Do you agree?

jianlinliu · 2020-06-28T03:00:32Z

LGTM. @jiajliu Can you help review this from your side?

jiajliu · 2020-06-28T04:41:00Z

There is a note in official doc https://docs.openshift.com/container-platform/4.4/updating/updating-cluster-between-minor.html.

Because of the difficulty of changing update channels by using oc, use the web console to change the update channel. It is recommended to complete the update process within the web console. You can follow the steps in Updating a cluster within a minor version by using the CLI to complete the update after you change to a 4.4 channel.

But from web console, we don't provide null channel in "Channel" option currently. So my suggestion here is that, we'd better to recommend users to clear channel trough CLI and provide the command to clear channel.

kalexand-rh · 2020-07-14T21:46:29Z

@LalatenduMohanty, @wking, do you have the command to clear the upgrade channel?

LalatenduMohanty · 2020-07-17T13:28:38Z

@LalatenduMohanty, @wking, do you have the command to clear the upgrade channel?

$ oc patch clusterversion/version --patch '{"spec":{"channel":""}}' --type=merge would clear the channel. But I think on a fresh installed cluster the channel will not be set. Users need to clear it only if it is set already.

wking · 2020-07-18T22:02:36Z

But I think on a fresh installed cluster the channel will not be set.

This is only true in CI since openshift/release#8631. User installs should have default channels, see openshift/installer#3848.

wking · 2020-09-18T21:28:30Z

Is this blocked on docs with an oc patch ... command to clear the channel? I'll try to get an oc wrapper around channel maintenance in place in the meantime...

wking · 2020-09-18T23:52:19Z

I've floated openshift/oc#576 for convenient, patch-free channel management.

openshift-bot · 2020-12-18T04:36:59Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

wking · 2020-12-19T22:25:56Z

/lifecycle frozen

Still trying to get review on openshift/oc#576. Now that 4.7 is in feature freeze, I'll push again once 4.7 forks off master and 4.8 opens up for new features.

vikram-redhat · 2021-05-06T21:03:58Z

@wking is this still valid?

wking · 2021-05-06T22:18:52Z

@wking is this still valid?

Yeah, we still want to recommend clearing the channel as the way to get the CVO to stop trying to poll the configured upstream. @jiajliu sort of blocked this PR because we didn't have a convenient way to clear the channel short of oc patch .... I have not been successful in motivating folks to review openshift/oc#576, but will do another round of begging once master opens for 4.9. It's also possible that the console folks have landed something that makes clearing your channel easy; I'll check on that front. And personally, I think we should be distributing this advice, even if we can't make up our minds about how we want customers to accomplish the clearing. And I'm fine recommending the patch command if that's our current best option, even if it isn't particularly elegant.

netlify · 2021-06-08T21:19:50Z

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: 4244510

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/6100461cd998620007195424

😎 Browse the preview: https://deploy-preview-22252--osdocs.netlify.app/openshift-enterprise/latest/updating/updating-cluster-between-minor

wking · 2021-06-08T21:28:44Z

Rebased onto master with e8552a5732 -> bf742cc4e5.

wking · 2021-07-07T21:33:33Z

I've pushed bf742cc4e -> e494b8661, rebasing onto master and updating to mention oc adm upgrade channel for clearing channels (just landed for 4.9 via openshift/oc#576).

wking · 2021-07-07T21:37:10Z

And I've pushed e494b8661 -> a0f42786e to update the:

Because of the difficulty of changing update channels by using oc...

language mentioned earlier, and instead mention oc adm upgrade channel ....

jiajliu · 2021-07-08T02:37:12Z

LGTM.

jiajliu · 2021-07-08T02:51:25Z

@wking @LalatenduMohanty Since we introduce oc adm upgrade channel command in this pr(for official doc), and i notice pr #576 has been merged now. I think it will be available soon in v4.9. Do you think QE should have some test against the new added subcommand? If so, we'd better have a jira us to track it, so that QE can involve it. HDYT?

LalatenduMohanty

/lgtm

wking · 2021-07-22T18:11:55Z

If so, we'd better have a jira us to track it, so that QE can involve it.

OTA-416 is our tracker for this change, if that's useful for QE to hang some test-cases on.

jiajliu · 2021-07-23T02:01:30Z

If so, we'd better have a jira us to track it, so that QE can involve it.

OTA-416 is our tracker for this change, if that's useful for QE to hang some test-cases on.

QE will follow up asap.

jeana-redhat

Just a couple minor suggestions.

modules/understanding-upgrade-channels.adoc

updating/updating-cluster-between-minor.adoc

openshift-ci · 2021-07-27T17:42:10Z

New changes are detected. LGTM label has been removed.

I would prefer to configure this by clearing the 'upstream' setting, which seems more intuitive for "there is no upstream" to me. But sadly, it seems that the CVO has been falling back to a default URI when the ClusterVersion upstream is empty since way back [1,2], and that this behavior is enshrined in the API [3]. Although the channel docs also talk about defaults [4], the only channel defaulting in the CVO is when creating a ClusterVersion object after the in-cluster copy was (accidentally?) deleted [5]. So maybe we could talk folks into adjusting the CVO logic to return NoUpstream in the empty-upstream case, but at the moment, clearing the channel is the best approach for "the CVO keeps complaining that it can't hit the upstream, and I want ot quiet it down [6]". The 'oc adm upgrade channel' command just landed for 4.9 in [7]. [1]: https://github.com/openshift/cluster-version-operator/blame/2c4931dc283c551938be1a00fee290de0b79d99c/pkg/cvo/availableupdates.go#L27-L31 [2]: openshift/cluster-version-operator@ab4d84a#diff-78f2af341fa49292dd6930f378018867R24 [3]: https://github.com/openshift/api/blame/0422dc17083e9e8df18d029f3f34322e96e9c326/config/v1/types_cluster_version.go#L56-L57 [4]: https://github.com/openshift/api/blame/0422dc17083e9e8df18d029f3f34322e96e9c326/config/v1/types_cluster_version.go#L62-L63 [5]: https://github.com/openshift/cluster-version-operator/blob/2c4931dc283c551938be1a00fee290de0b79d99c/pkg/cvo/cvo.go#L602 [6]: https://bugzilla.redhat.com/show_bug.cgi?id=1827378 [7]: openshift/oc#576

jeana-redhat · 2021-07-27T18:14:22Z

/cherrypick enterprise-4.9

openshift-cherrypick-robot · 2021-07-27T18:15:07Z

@jeana-redhat: new pull request created: #34900

Details

In response to this:

/cherrypick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wking force-pushed the recommend-no-channel branch from 9afff16 to 635018c Compare May 19, 2020 04:01

openshift-ci-robot assigned kalexand-rh Jun 8, 2020

LalatenduMohanty suggested changes Jun 18, 2020

View reviewed changes

modules/understanding-upgrade-channels.adoc Outdated Show resolved Hide resolved

kalexand-rh reviewed Jun 23, 2020

View reviewed changes

modules/understanding-upgrade-channels.adoc Outdated Show resolved Hide resolved

wking force-pushed the recommend-no-channel branch 2 times, most recently from eb93d29 to e8552a5 Compare June 24, 2020 21:31

wking mentioned this pull request Aug 28, 2020

data/manifests/bootkube/cvo-overrides: Drop the explicit upstream openshift/installer#4112

Merged

openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 18, 2020

openshift-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 19, 2020

wking mentioned this pull request Mar 31, 2021

docs/user/status: Mention channel-clearing for VersionNotFound openshift/cluster-version-operator#541

Merged

openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 6, 2021

wking force-pushed the recommend-no-channel branch from e8552a5 to bf742cc Compare June 8, 2021 21:18

openshift-ci bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 8, 2021

wking force-pushed the recommend-no-channel branch from bf742cc to e494b86 Compare July 7, 2021 21:32

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2021

wking force-pushed the recommend-no-channel branch from e494b86 to a0f4278 Compare July 7, 2021 21:35

LalatenduMohanty approved these changes Jul 22, 2021

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2021

jeana-redhat added the branch/enterprise-4.9 label Jul 26, 2021

jeana-redhat reviewed Jul 26, 2021

View reviewed changes

modules/understanding-upgrade-channels.adoc Outdated Show resolved Hide resolved

updating/updating-cluster-between-minor.adoc Outdated Show resolved Hide resolved

wking force-pushed the recommend-no-channel branch from a0f4278 to 4085e6d Compare July 27, 2021 17:42

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2021

wking force-pushed the recommend-no-channel branch from 4085e6d to 4244510 Compare July 27, 2021 17:44

jeana-redhat added peer-review-done Signifies that the peer review team has reviewed this PR and removed lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. labels Jul 27, 2021

jeana-redhat added this to the Future Release milestone Jul 27, 2021

jeana-redhat merged commit 45d8514 into openshift:main Jul 27, 2021

openshift-cherrypick-robot mentioned this pull request Jul 27, 2021

[enterprise-4.9] modules/understanding-upgrade-channels: Recommend clearing channel #34900

Merged

wking deleted the recommend-no-channel branch July 27, 2021 18:20

wking mentioned this pull request Aug 17, 2021

OSDOCS-2428: Adding CVO conditions #35453

Closed

vikram-redhat modified the milestones: Future Release, OCP 4.9 GA Oct 18, 2021

opayne1 mentioned this pull request Nov 12, 2021

BZ2014246: Correcting command to upgrade clusterversion channel #38686

Merged

modules/understanding-upgrade-channels: Recommend clearing channel #22252

modules/understanding-upgrade-channels: Recommend clearing channel #22252

Uh oh!

Conversation

wking commented May 19, 2020

Uh oh!

wking commented Jun 8, 2020

Uh oh!

Uh oh!

kalexand-rh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kalexand-rh commented Jun 24, 2020

Uh oh!

jianlinliu commented Jun 28, 2020

Uh oh!

jiajliu commented Jun 28, 2020

Uh oh!

kalexand-rh commented Jul 14, 2020

Uh oh!

LalatenduMohanty commented Jul 17, 2020

Uh oh!

wking commented Jul 18, 2020

Uh oh!

wking commented Sep 18, 2020

Uh oh!

wking commented Sep 18, 2020

Uh oh!

openshift-bot commented Dec 18, 2020

Uh oh!

wking commented Dec 19, 2020

Uh oh!

vikram-redhat commented May 6, 2021

Uh oh!

wking commented May 6, 2021

Uh oh!

netlify bot commented Jun 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wking commented Jun 8, 2021

Uh oh!

wking commented Jul 7, 2021

Uh oh!

wking commented Jul 7, 2021

Uh oh!

jiajliu commented Jul 8, 2021

Uh oh!

jiajliu commented Jul 8, 2021

Uh oh!

LalatenduMohanty left a comment

Choose a reason for hiding this comment

Uh oh!

wking commented Jul 22, 2021

Uh oh!

jiajliu commented Jul 23, 2021

Uh oh!

jeana-redhat left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

openshift-ci bot commented Jul 27, 2021

Uh oh!

jeana-redhat commented Jul 27, 2021

Uh oh!

openshift-cherrypick-robot commented Jul 27, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

netlify bot commented Jun 8, 2021 •

edited

Loading