Reorganize Image configuration resources topic #28268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
size/M
|
The preview will be available shortly at:
|
mburke5678
force-pushed
the
image-registry-reorg
branch
2 times, most recently
from
baa61ad to
48e9ebe
Compare
|
@mburke5678 thanks for the edits, lgtm |
ahardin-rh
reviewed
Dec 23, 2020
ahardin-rh
reviewed
Dec 23, 2020
Contributor
There was a problem hiding this comment.
looks like an unnecessary line break after "builds and"
ahardin-rh
reviewed
Dec 23, 2020
ahardin-rh
reviewed
Dec 23, 2020
ahardin-rh
reviewed
Dec 23, 2020
ahardin-rh
reviewed
Dec 23, 2020
ahardin-rh
reviewed
Dec 23, 2020
ahardin-rh
reviewed
Dec 23, 2020
ahardin-rh
reviewed
Dec 23, 2020
ahardin-rh
added
the
peer-review-done
Contributor
|
@mburke5678 Just very minor comments from me. Looking good! |
mburke5678
force-pushed
the
image-registry-reorg
branch
from
4b59071 to
e6a745f
Compare
Contributor
Author
|
/cherrypick enterprise-4.7 |
|
@mburke5678: new pull request created: #28302 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This was referenced Dec 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When documenting a 4.7 feature, I noticed the Image configuration resources topic could use a refresh.
One example CR shows two parameters that are not allowed together, for one.
New module for adding registries.
Split out the Importing insecure registries and blocking registries module into a module for insecure registries and one for blocking.
Other minor style edits throughout
This PR is based on 4.6. Changes are needed for 4.7, see #28152 (pending) and #28090.
Preview: http://file.rdu.redhat.com/~mburke/image-registry-reorg/openshift_images/image-configuration.html