Add UnqualifiedSearchRegistries to the Image CR #28152

mburke5678 · 2020-12-15T22:46:17Z

https://issues.redhat.com/browse/OSDOCS-1644

openshift-docs-preview-bot · 2020-12-21T17:11:00Z

The preview will be available shortly at:

modules/images-configuration-file.adoc: https://node-unqualifiedsearchregistries--ocpdocs.netlify.com/openshift-enterprise/latest/modules/images-configuration-file.html

mburke5678 · 2020-12-24T02:29:33Z

modules/images-configuration-allowed.adoc

This is an editorial change for consistency only. No need for QE review.

mburke5678 · 2020-12-24T02:30:15Z

modules/images-configuration-blocked.adoc

This is an editorial change for 4.7 MCO change previously reviewed. No need for QE review.

mburke5678 · 2020-12-24T02:30:28Z

modules/images-configuration-file.adoc

This is an editorial change for consistency only. No need for QE review.

mburke5678 · 2020-12-24T02:35:37Z

modules/images-configuration-insecure.adoc

This is an editorial change for consistency only. No need for QE review.

mburke5678 · 2020-12-24T02:40:35Z

modules/images-configuration-parameters.adoc

This is an editorial change for consistency only. No need for QE review.

mburke5678 · 2020-12-24T02:41:01Z

modules/images-configuration-parameters.adoc

QE, please review this new text.

mburke5678 · 2020-12-24T02:41:20Z

modules/images-configuration-shortname.adoc

QE, please review this new text.

mburke5678 · 2020-12-24T03:06:04Z

@sunilcio PTAL. I made several editorial changes to ensure consistency throughout the other modules in the assembly. Please feel free to not review these changes.

mburke5678 · 2021-01-04T14:23:13Z

@sunilcio PTAL

sunilcio · 2021-01-06T14:47:04Z

@mburke5678 thanks, lgtm!

codyhoag

Just a few suggestions; looks good otherwise! Just a reminder to add the labels before merging 🙂

codyhoag · 2021-01-06T19:10:06Z

modules/images-configuration-shortname.adoc

Suggested change

The Machine Config Operator (MCO) watches the `image.config.openshift.io/cluster` resource for any changes to the registries. When the MCO detects a change, it drains the nodes, applies the change, and uncordons the nodes. After the nodes return to the `Ready` state, if the `containerRuntimeSearchRegistries` parameter is added, the MCO and creates a file in the `/etc/containers/registries.conf.d` directory on each node with the listed registries. The file overrides the default list of unqualified search registries in the `/host/etc/containers/registries.conf` file. There is no way to fall back to the default list of unqualified search registries.

The Machine Config Operator (MCO) watches the `image.config.openshift.io/cluster` resource for any changes to the registries. When the MCO detects a change, it drains the nodes, applies the change, and uncordons the nodes. After the nodes return to the `Ready` state, if the `containerRuntimeSearchRegistries` parameter is added, the MCO creates a file in the `/etc/containers/registries.conf.d` directory on each node with the listed registries. The file overrides the default list of unqualified search registries in the `/host/etc/containers/registries.conf` file. There is no way to fall back to the default list of unqualified search registries.

codyhoag · 2021-01-06T19:12:06Z

modules/images-configuration-shortname.adoc

Suggested change

The `containerRuntimeSearchRegistries` parameter works only with the Podman and CRI-O container engines and the registries in the list can be used only in pod specs, not in builds and image streams.

The `containerRuntimeSearchRegistries` parameter works only with the Podman and CRI-O container engines. The registries in the list can be used only in pod specs, not in builds and image streams.

codyhoag · 2021-01-06T19:22:42Z

modules/images-configuration-shortname.adoc

The + markers are currently rendering (line 83 and 88). I'd suggest making this verification step a numbered step, which would fix the rendering issue.

. To check that the registries have been added, use the following command on a node:

mburke5678 · 2021-01-06T20:22:25Z

/cherrypick enterprise-4.7

openshift-cherrypick-robot · 2021-01-06T20:22:37Z

@mburke5678: new pull request created: #28416

Details

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 15, 2020

mburke5678 force-pushed the node-unqualifiedsearchregistries branch from 25292cc to c1e5bc5 Compare December 21, 2020 16:10

openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 21, 2020

mburke5678 mentioned this pull request Dec 23, 2020

Reorganize Image configuration resources topic #28268

Merged

mburke5678 force-pushed the node-unqualifiedsearchregistries branch from 381597c to 651ab26 Compare December 24, 2020 02:28

mburke5678 commented Dec 24, 2020

View reviewed changes

modules/images-configuration-file.adoc Outdated

Copy link

Contributor Author

mburke5678 Dec 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an editorial change for consistency only. No need for QE review.

mburke5678 commented Dec 24, 2020

View reviewed changes

modules/images-configuration-parameters.adoc Outdated

Copy link

Contributor Author

mburke5678 Dec 24, 2020 •

edited

Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QE, please review this new text.

mburke5678 commented Dec 24, 2020

View reviewed changes

modules/images-configuration-shortname.adoc Outdated

Copy link

Contributor Author

mburke5678 Dec 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QE, please review this new text.

mburke5678 mentioned this pull request Jan 6, 2021

Adding MCO behavior changes from #28090 #28388

Merged

mburke5678 force-pushed the node-unqualifiedsearchregistries branch 3 times, most recently from 5fe0c9a to 578c1e4 Compare January 6, 2021 18:55

codyhoag self-requested a review January 6, 2021 19:02

codyhoag reviewed Jan 6, 2021

View reviewed changes

codyhoag added the peer-review-done Signifies that the peer review team has reviewed this PR label Jan 6, 2021

Add UnqualifiedSearchRegistries to the Image CR

c62f761

mburke5678 force-pushed the node-unqualifiedsearchregistries branch from 578c1e4 to c62f761 Compare January 6, 2021 20:12

mburke5678 added the branch/enterprise-4.7 label Jan 6, 2021

mburke5678 added this to the Future Release milestone Jan 6, 2021

mburke5678 merged commit b8c436f into openshift:master Jan 6, 2021

mburke5678 deleted the node-unqualifiedsearchregistries branch January 6, 2021 20:21

openshift-cherrypick-robot mentioned this pull request Jan 6, 2021

[enterprise-4.7] Add UnqualifiedSearchRegistries to the Image CR #28416

Merged

vikram-redhat modified the milestones: Future Release, OCP 4.7 GA Feb 24, 2021

ahardin-rh mentioned this pull request Mar 24, 2021

Removed modules/machineconfig-modify-registry.adoc procedure #30880

Merged

	The `containerRuntimeSearchRegistries` parameter works only with the Podman and CRI-O container engines and the registries in the list can be used only in pod specs, not in builds and image streams.
	The `containerRuntimeSearchRegistries` parameter works only with the Podman and CRI-O container engines. The registries in the list can be used only in pod specs, not in builds and image streams.

Add UnqualifiedSearchRegistries to the Image CR #28152

Add UnqualifiedSearchRegistries to the Image CR #28152

Uh oh!

Conversation

mburke5678 commented Dec 15, 2020

Uh oh!

openshift-docs-preview-bot commented Dec 21, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mburke5678 Dec 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mburke5678 commented Dec 24, 2020

Uh oh!

mburke5678 commented Jan 4, 2021

Uh oh!

sunilcio commented Jan 6, 2021

Uh oh!

codyhoag left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mburke5678 commented Jan 6, 2021 • edited by openshift-ci-robot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-cherrypick-robot commented Jan 6, 2021 • edited by openshift-ci-robot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

mburke5678 Dec 24, 2020 •

edited

Loading

codyhoag left a comment •

edited

Loading

mburke5678 commented Jan 6, 2021 •

edited by openshift-ci-robot

Loading

openshift-cherrypick-robot commented Jan 6, 2021 •

edited by openshift-ci-robot

Loading