Skip to content

Conversation

@bobfuru
Copy link
Contributor

@bobfuru bobfuru commented Oct 19, 2020

Mostly, this PR fixes changes that were made in modules/installation-user-infra-machines-static-network.adoc in #26184. (See my inline comments in that merged PR for more details.)

IIUC, the changes that were made were cosmetic. In other words, they are not hiding any functionality to a certain set of users (i.e., Z-Power).

What was changed in that file minimizes the level of information that follows. The three bulleted items describe the three ways that a user can configure advanced networking: at the live installer boot prompt, by using specific core.inst boot options, or by passing arguments directly to coreos-installer. The tables that follow that intro cover these three scenarios.

It is my conclusion that the changes in this new PR should be acceptable without conditionals necessary, and that we should therefore be able to merge this PR and CP it to 4.6 with no additional tags added. But I might be missing the bigger picture.

@vikram-redhat or @codyhoag Do you see any issue with merging and CP'ing this to 4.6?

PREVIEW LINKS

@bobfuru bobfuru added this to the Future Release milestone Oct 19, 2020
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 19, 2020
@openshift-docs-preview-bot

The preview will be available shortly at:

Comment on lines +45 to +46
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a follow-up fix to #26512.

@codyhoag
Copy link
Contributor

@bobfuru one question: I see the Advanced RHCOS installation reference used in the IBM Power installation docs too here. I don't know much background on the subject here, so I don't know what should and shouldn't be included 😅. Do you think the references to bare metal are out of place there? If not, I think these changes are good from my perspective.

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 20, 2020
@bobfuru
Copy link
Contributor Author

bobfuru commented Oct 20, 2020

@codyhoag I don't know too much about the IBM Power docs, either. I was aware that Advanced RHCOS installation reference is used in the link you mentioned, and it doesn't seem out of place to me. Ideally, that should have been included in the module metadata for cross-referencing but it doesn't seem that that happened.

Another question I wonder about is why Advanced RHCOS installation reference was included in only 1 of the 2 "Installing on IBM Power" assemblies ("Restricted network IBM Power installation" but not "Installing a cluster on IBM Power"). For bare metal install docs, we add it to child assemblies. Example here.

@vikram-redhat I agree with Cody, I think we are good with these changes, but I also suspect it should be added to the installing-ibm-power.adoc file, too. So I've done so.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that we updated the title of this module but it wasn't reflected in this reference.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I noted in the comments of this PR, I think this should be added to this assembly as well.

@bobfuru bobfuru added the peer-review-done Signifies that the peer review team has reviewed this PR label Oct 20, 2020
@bobfuru
Copy link
Contributor Author

bobfuru commented Oct 20, 2020

FYI, @ktania46

@bobfuru bobfuru merged commit dcbc0ac into openshift:master Oct 20, 2020
@bobfuru
Copy link
Contributor Author

bobfuru commented Oct 20, 2020

/cherrypick enterprise-4.6

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Oct 20, 2020

@bobfuru: new pull request created: #26593

Details

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.6 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants