Skip to content

Power 4.6 Direct install, restricted install and RN #26184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vikram-redhat merged 1 commit into from
Oct 15, 2020
Merged

Power 4.6 Direct install, restricted install and RN #26184

vikram-redhat merged 1 commit into from
Oct 15, 2020

Conversation

@ktania46
Copy link
Contributor

@ktania46 ktania46 commented Oct 7, 2020

Pull Request for power 4.6
@vikram-redhat

@openshift-ci-robot openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 7, 2020
@vikram-redhat vikram-redhat added the peer-review-needed Signifies that the peer review team needs to review this PR label Oct 9, 2020
@vikram-redhat
Copy link
Contributor

vikram-redhat commented Oct 9, 2020

@kalexand-rh to peer review.

kalexand-rh
kalexand-rh reviewed Oct 9, 2020
View reviewed changes
release_notes/ocp-4-6-release-notes.adoc Outdated
Copy link
Contributor

@kalexand-rh kalexand-rh Oct 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
** Red Hat OpenShift Service Mesh(istio, jaeger, kiali)
** Red Hat OpenShift Service Mesh (istio, jaeger, kiali)

release_notes/ocp-4-6-release-notes.adoc Outdated
Copy link
Contributor

@kalexand-rh kalexand-rh Oct 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
** OpenShift Container Platform Metering
** {product-title} Metering

Copy link
Contributor

@kalexand-rh kalexand-rh Oct 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a duplicate of line 654.

release_notes/ocp-4-6-release-notes.adoc Outdated
Copy link
Contributor

@kalexand-rh kalexand-rh Oct 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
** Multus Plugins (SR-IOV, IPVAN, Bridge with VLAN, Static IPAM)SR-IOV CNI plug-in
** Multus Plugins (SR-IOV, IPVAN, Bridge with VLAN, Static IPAM)
** SR-IOV CNI plug-in

release_notes/ocp-4-6-release-notes.adoc Outdated
Copy link
Contributor

@kalexand-rh kalexand-rh Oct 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Installer Provisioned Infrastructure (IPI)
* Installer-provisioned infrastructure

release_notes/ocp-4-6-release-notes.adoc Outdated
Copy link
Contributor

@kalexand-rh kalexand-rh Oct 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* User Provisioned Infrastructure (UPI) deployment scenario on Bare-metal
* User-provisioned infrastructure deployment scenario on bare-metal

@openshift-docs-preview-bot
Copy link

openshift-docs-preview-bot commented Oct 11, 2020

The preview will be available shortly at:

@jboxman
Copy link
Contributor

jboxman commented Oct 11, 2020

@ktania46 is there any intersection with this #26122?

@ktania46
Copy link
Contributor Author

ktania46 commented Oct 12, 2020

@SNiemann15

@openshift-ci-robot openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 12, 2020
@SNiemann15 SNiemann15 mentioned this pull request Oct 12, 2020
Closed
@manojnkumar
Copy link

manojnkumar commented Oct 13, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 13, 2020

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 13, 2020
@manojnkumar
Copy link

manojnkumar commented Oct 13, 2020

/lgtm

1 similar comment
@bziouechn
Copy link

bziouechn commented Oct 13, 2020

/lgtm

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 13, 2020

@bziouechn: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 13, 2020
@arcprabh
Copy link

arcprabh commented Oct 14, 2020

/lgtm

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 14, 2020

@arcprabh: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@arcprabh
Copy link

arcprabh commented Oct 14, 2020

@mcfadden

@codyhoag codyhoag mentioned this pull request Oct 14, 2020
Merged
@vikram-redhat
Copy link
Contributor

vikram-redhat commented Oct 15, 2020

All peer reviews are done. QE has given ack for both Power and Z. I am merging this.

@vikram-redhat vikram-redhat merged commit f208b05 into openshift:enterprise-4.6 Oct 15, 2020
@codyhoag codyhoag mentioned this pull request Oct 15, 2020
Merged
bobfuru
bobfuru reviewed Oct 19, 2020
View reviewed changes
modules/installation-user-infra-machines-static-network.adoc

a|Specify multiple network interfaces by specifying multiple `ip=` entries.

|Specify multiple network interfaces by specifying multiple `ip=` entries.
Copy link
Contributor

@bobfuru bobfuru Oct 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why these were dropped. The a is needed in some of these cells to properly display formatting.

bobfuru
bobfuru reviewed Oct 19, 2020
View reviewed changes
modules/registry-configuring-storage-baremetal.adoc
* If the storage type is `emptyDIR`, the replica number cannot be greater than `1`.
* If the storage type is `NFS`, you must enable the `no_wdelay` and `root_squash` mount options. For example:
+
* If the storage type is `NFS`, and you want to scale up the registry Pod by setting `replica>1` you must enable the `no_wdelay` mount option. For example:
Copy link
Contributor

@bobfuru bobfuru Oct 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We removed NFS examples in image registry docs. See these lines as example: https://github.com/openshift/openshift-docs/pull/26512/files#diff-4af87df61050e4b8fe830bbb6be46aaab303d94d8e0b79e1ede86f612413395dL72-L103

@bobfuru bobfuru mentioned this pull request Oct 19, 2020
Merged
bobfuru
bobfuru reviewed Oct 19, 2020
View reviewed changes
modules/installation-user-infra-machines-static-network.adoc
Comment on lines +10 to +12
If you install {op-system-first} from an ISO image, you can add kernel arguments
when you boot that image to configure the node's networking.
The following table describes and illustrates how to use those kernel arguments.
Copy link
Contributor

@bobfuru bobfuru Oct 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As noted in #26559, I don't see why this text was changed. The original wording introduces the three options and tables we provide for advanced networking config in this section.

@sjstout
Copy link

sjstout commented Oct 28, 2020

LGTM! Thanks, Vikram!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kalexand-rh kalexand-rh kalexand-rh left review comments

+2 more reviewers

@bobfuru bobfuru bobfuru left review comments

@SNiemann15 SNiemann15 SNiemann15 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@manojnkumar manojnkumar

Labels

peer-review-needed Signifies that the peer review team needs to review this PR size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.