Skip to content

Add Kuryr caveats related to ShiftStack availability zone support #26199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
maxwelldb merged 2 commits into from
Oct 15, 2020
Merged

Add Kuryr caveats related to ShiftStack availability zone support #26199

maxwelldb merged 2 commits into from
Oct 15, 2020

Conversation

@maxwelldb
Copy link
Contributor

@maxwelldb maxwelldb commented Oct 7, 2020

Context: https://issues.redhat.com/browse/OSDOCS-1492

@luis5tb Does this address what you were talking about here?

#24834 (comment)

@maxwelldb maxwelldb added this to the Next Release milestone Oct 7, 2020
@maxwelldb maxwelldb requested a review from luis5tb October 7, 2020 17:53
@maxwelldb maxwelldb self-assigned this Oct 7, 2020
@openshift-ci-robot openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 7, 2020
@maxwelldb
Copy link
Contributor Author

maxwelldb commented Oct 7, 2020 •
edited
Loading

(PR is messy right now--most of the commits will resolve after #24834 is merged.)

@maxwelldb maxwelldb force-pushed the osp-azs-kuryr-caveats-osdocs1492 branch from ad52c2f to e648b6d Compare October 7, 2020 18:03
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 7, 2020
@openshift-docs-preview-bot
Copy link

openshift-docs-preview-bot commented Oct 7, 2020

The preview will be available shortly at:

@luis5tb
Copy link
Contributor

luis5tb commented Oct 8, 2020

Context: https://issues.redhat.com/browse/OSDOCS-1492

@luis5tb Does this address what you were talking about here?

#24834 (comment)

Looks great! thanks!

@maxwelldb
Copy link
Contributor Author

maxwelldb commented Oct 8, 2020

Thanks!

Merge is blocked by default zone behavior detailed in #24834.

@maxwelldb
Copy link
Contributor Author

maxwelldb commented Oct 8, 2020

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 8, 2020
@maxwelldb
Copy link
Contributor Author

maxwelldb commented Oct 9, 2020

/unhold

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 9, 2020
@maxwelldb maxwelldb force-pushed the osp-azs-kuryr-caveats-osdocs1492 branch from e648b6d to 9832089 Compare October 9, 2020 19:25
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 9, 2020
@maxwelldb maxwelldb force-pushed the osp-azs-kuryr-caveats-osdocs1492 branch from 9832089 to 8cc9ff2 Compare October 9, 2020 19:33
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 9, 2020
@maxwelldb maxwelldb requested a review from eurijon October 9, 2020 19:35
@maxwelldb
Copy link
Contributor Author

maxwelldb commented Oct 9, 2020

Netlify preview should be updated within an hour: https://osp-azs-kuryr-caveats-osdocs1492--ocpdocs.netlify.app/openshift-enterprise/latest/installing/installing_openstack/installing-openstack-installer-custom.html#installation-configuration-parameters_installing-openstack-installer-custom

@maxwelldb maxwelldb force-pushed the osp-azs-kuryr-caveats-osdocs1492 branch from c99b6fb to afd7f0e Compare October 9, 2020 19:37
@eurijon
Copy link

eurijon commented Oct 15, 2020

This PR looks good! thanks!

@maxwelldb
Copy link
Contributor Author

maxwelldb commented Oct 15, 2020

@eurijon Thanks!

kalexand-rh
kalexand-rh reviewed Oct 15, 2020
View reviewed changes
Copy link
Contributor

@kalexand-rh kalexand-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxwelldb
Copy link
Contributor Author

maxwelldb commented Oct 15, 2020

Thanks!

@maxwelldb maxwelldb merged commit 57e6691 into openshift:master Oct 15, 2020
@maxwelldb
Copy link
Contributor Author

maxwelldb commented Oct 15, 2020 •
edited by openshift-ci-robot
Loading

/cherry-pick enterprise-4.6

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 15, 2020
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Oct 15, 2020 •
edited by openshift-ci-robot
Loading

@maxwelldb: new pull request created: #26503

Details

In response to this:

/cherry-pick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kalexand-rh kalexand-rh kalexand-rh left review comments

@luis5tb luis5tb Awaiting requested review from luis5tb

@eurijon eurijon Awaiting requested review from eurijon

Assignees

@maxwelldb maxwelldb

Labels

branch/enterprise-4.6 size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

7 participants

@maxwelldb @openshift-docs-preview-bot @luis5tb @eurijon @openshift-cherrypick-robot @kalexand-rh @openshift-ci-robot