Param changes for OSP AZ support

[maxwelldb]

https://issues.redhat.com/browse/OSDOCS-1277

[maxwelldb]

@iamemilio Not at all sure if I read the upstream changes for this correctly--especially WRT machinesets. Can you review?

FYI @pierreprinetti

[openshift-docs-preview-bot]

The preview will be available shortly at:

• https://osp-azs-osdocs1277--ocpdocs.netlify.com/

[maxwelldb]

Added 807633f due to @pierreprinetti's feedback.

[pierreprinetti]

LGTM 👍

[maxwelldb]

Thanks!

[luis5tb]

This is missing a couple of important points:

• It must highlight that it is availability zones just for nova, not for cinder or other components that may needed (octavia, manila?)
• Related to Octavia LoadBalancer VMs, we need to highlight that when deploying with Kuryr, as Octavia does not support availability zones, that means that event though all the OCP VMs will be in the desired AZs, the Load Balancers will not. And there is 2 cases for Kuryr. One where ovn-octavia provider is used, and thus only one amphora VM is there not maching the AZ. And the other case where amphora provider is used, thus any OCP service will be backed up by an amphora VM which may not be running on the stated AZ.

[luis5tb]

This is missing a couple of important points:

* It must highlight that it is availability zones just for nova, not for cinder or other components that may needed (octavia, manila?)

* Related to Octavia LoadBalancer VMs, we need to highlight that when deploying with Kuryr, as Octavia does not support availability zones, that means that event though all the OCP VMs will be in the desired AZs, the Load Balancers will not. And there is 2 cases for Kuryr. One where ovn-octavia provider is used, and thus only one amphora VM is there not maching the AZ. And the other case where amphora provider is used, thus any OCP service will be backed up by an amphora VM which may not be running on the stated AZ.

And for the record, I sent this to openshift/installer docs: openshift/installer#4109

[maxwelldb]

@luis5tb c5d23e3 adds Compute/Nova to the parameters.

As to this:

Related to Octavia LoadBalancer VMs, we need to highlight that when deploying with Kuryr, as Octavia does not support availability zones, that means that event though all the OCP VMs will be in the desired AZs, the Load Balancers will not. And there is 2 cases for Kuryr. One where ovn-octavia provider is used, and thus only one amphora VM is there not maching the AZ. And the other case where amphora provider is used, thus any OCP service will be backed up by an amphora VM which may not be running on the stated AZ.

Would you agree that this information should be added to the existing body of Kuryr + load balancing content, or is it important enough to add it to this more general list of parameters?

[luis5tb]

@luis5tb c5d23e3 adds Compute/Nova to the parameters.

As to this:

Related to Octavia LoadBalancer VMs, we need to highlight that when deploying with Kuryr, as Octavia does not support availability zones, that means that event though all the OCP VMs will be in the desired AZs, the Load Balancers will not. And there is 2 cases for Kuryr. One where ovn-octavia provider is used, and thus only one amphora VM is there not maching the AZ. And the other case where amphora provider is used, thus any OCP service will be backed up by an amphora VM which may not be running on the stated AZ.

Would you agree that this information should be added to the existing body of Kuryr + load balancing content, or is it important enough to add it to this more general list of parameters?

Sounds good!

[maxwelldb]

@mandre @morenod Any updates about this?

[maxwelldb]

/hold

[morenod]

Lgtm

[maxwelldb]

See it in action at https://osp-azs-osdocs1277--ocpdocs.netlify.app/openshift-enterprise/latest/installing/installing_openstack/installing-openstack-installer-custom.html#installation-configuration-parameters_installing-openstack-installer-custom

[codyhoag]

A couple nits; otherwise, the changes look good!

Make sure to squash your commits before merging 🙂

[maxwelldb]

/cherry-pick enterprise-4.6

[openshift-cherrypick-robot]

@maxwelldb: #24834 failed to apply on top of branch "enterprise-4.6":

Applying: Add availability zone support for ShiftStack
Using index info to reconstruct a base tree...
M	modules/installation-configuration-parameters.adoc
Falling back to patching base and 3-way merge...
Auto-merging modules/installation-configuration-parameters.adoc
CONFLICT (content): Merge conflict in modules/installation-configuration-parameters.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Add availability zone support for ShiftStack
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherry-pick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.