Add MySQL settings #246
Merged
Add MySQL settings #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Also: I didn't include defaults, since they weren't in v2 docs and I don't know if it'd be a good idea. If you'd like to include them, they're in the readme. |
Contributor
|
Thanks, @mnagy. I'll merge and let @tpoitras make any changes along with his WIP #242 (per https://trello.com/c/jPzgJkic). |
sbeskin-redhat
pushed a commit
to sbeskin-redhat/openshift-docs
that referenced
this pull request
Oct 24, 2022
WINDUP-2162: Adjusted OpenShift installation instructions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are basically taken over from the v2 cartridge. I don't know
whether it's a good idea to create a new settings section, so feel free
to change that.
Also. I was thinking we could add references to the MySQL settings that are
directly affected by these env vars. These can be seen in the config
template as '${}'-escaped variables:
https://github.com/openshift/mysql/blob/master/5.5/contrib/my.cnf.template