-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Changes to MySQL image for style and readability #242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The changes LGTM, as far as technical accuracy is concerned. |
02a2bc6 to
bb9628c
Compare
|
@mnagy -- can you tech review this latest update? Since we use replaceable text instead of telling them to actually use "user" and "pass", I have updated from -uuser to --user=< user > Please verify this is still correct. The MySQL docs seems to verify I can use the variant of that command. (http://dev.mysql.com/doc/refman/5.6/en/mysql.html) |
|
@tpoitras yes, this is correct. Though you referenced 5.6 instead of 5.5 :) One non-technical question/suggestion: We tell user that he can get the mysql image from docker, but we don't mention the image name, except in the later example, but that seems to be hard to see at first glance. Perhaps we should mention somewhere that it's openshift/mysql-55-centos7 or openshift/mysql-55-rhel7? Maybe even elaborate a bit on how we name them generally? |
|
@mnagy -- thanks, I've included some more details on the name of the docker image and how to pull it. If that looks good to you, then I think we are done here. :) |
|
LGTM |
|
@adellape @CowboysFan -- this should be good for merge now |
|
|
Changes to MySQL image for style and readability
Corrected name.
Based on content submitted by PR#241 and PR#210.
Related to Trello card: https://trello.com/c/jPzgJkic
Ping @mnagy for Tech Review. Questions for you, Martin: