Skip to content

Conversation

@wking
Copy link
Member

@wking wking commented Aug 5, 2020

And link the SemVer spec so folks can figure out what that means. This allows us to cover -fc too, since we may be releasing things like 4.6.0-fc.0 going forward.

This would technically apply to all of our releases, but since we are only likely to get FC releases for 4.6 and later, I don't see a need to backport it.

…lease version"

And link the SemVer spec so folks can figure out what that means.
This allows us to cover -fc too, since we may be releasing things like
4.6.0-fc.0 going forward [1].

[1]: openshift/cincinnati-graph-data#376
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 5, 2020
@vikram-redhat
Copy link
Contributor

@jianlinliu would you be able to ack this?

@kalexand-rh

@jianlinliu
Copy link

lgtm.

@kalexand-rh
Copy link
Contributor

@wking, I think we should clarify this more before 4.6 releases, but I think this is an ok way to nod at -fc for now.

@kalexand-rh kalexand-rh merged commit 40609c7 into openshift:master Aug 6, 2020
@kalexand-rh
Copy link
Contributor

/cherrypick enterprise-4.6

@openshift-cherrypick-robot

@kalexand-rh: new pull request created: #24528

Details

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking wking deleted the generalize-rc-to-pre-release branch August 6, 2020 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.6 size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants