Skip to content

Conversation

@openshift-bot
Copy link
Contributor

@openshift-bot openshift-bot commented Aug 5, 2020

This is a feature candidate (.fc is intentional). There is no advisory associated.

Please merge immediately.

wking added a commit to wking/openshift-docs that referenced this pull request Aug 5, 2020
…lease version"

And link the SemVer spec so folks can figure out what that means.
This allows us to cover -fc too, since we may be releasing things like
4.6.0-fc.0 going forward [1].

[1]: openshift/cincinnati-graph-data#376
@wking
Copy link
Member

wking commented Aug 5, 2020

"fc" is intentional for "Feature Candidate". These have upgrade edges like Release Candidates, but are not releasable.

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-bot, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 5, 2020
@openshift-merge-robot openshift-merge-robot merged commit 39730af into master Aug 5, 2020
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/openshift-docs that referenced this pull request Aug 6, 2020
…lease version"

And link the SemVer spec so folks can figure out what that means.
This allows us to cover -fc too, since we may be releasing things like
4.6.0-fc.0 going forward [1].

[1]: openshift/cincinnati-graph-data#376
wking added a commit to wking/cincinnati-graph-data that referenced this pull request Oct 2, 2020
Like adde027 (channels: Add candidate-4.5, fast-4.5, and
stable-4.5, 2020-03-12, openshift#113), but without candidate because we got
that in 713f464 (Enable 4.6.0-fc.0 in candidate channel(s),
2020-08-05, openshift#376).  This sets us up to avoid VersionNotFound issues
once [1] lands.

[1]: https://bugzilla.redhat.com/show_bug.cgi?id=1884760
@sdodson sdodson deleted the pr-candidate-4.6.0-fc.0 branch October 12, 2020 16:54
sdodson pushed a commit to sdodson/cincinnati-graph-data that referenced this pull request Dec 3, 2020
Like adde027 (channels: Add candidate-4.5, fast-4.5, and
stable-4.5, 2020-03-12, openshift#113), but without candidate because we got
that in 713f464 (Enable 4.6.0-fc.0 in candidate channel(s),
2020-08-05, openshift#376).  This sets us up to avoid VersionNotFound issues
once [1] lands.

[1]: https://bugzilla.redhat.com/show_bug.cgi?id=1884760
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants