Skip to content

openshift-sdn to ovn-kubernetes migration testing feedback #24445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jboxman merged 4 commits into from
Aug 17, 2020
+5 −5
Merged

openshift-sdn to ovn-kubernetes migration testing feedback #24445

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0a397e5
revise watch of openshift-sdn spindown
dlbewley Aug 3, 2020
ca27af4
more explicit watch of ovn-kubernetes spin down
dlbewley Aug 3, 2020
aa43222
capture backup of cluster network configuration
vagnerfarias Aug 4, 2020
d43e970
typos
dlbewley Aug 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions modules/nw-ovn-kubernetes-migration.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ Perform the migration only when an interruption in service is acceptable.
. To backup the configuration for the cluster network, enter the following command:
+
----
$ oc get Network.config.openshift.io cluster -o yaml
$ oc get Network.config.openshift.io cluster -o yaml > cluster-openshift-sdn.yaml
Comment thread
dlbewley marked this conversation as resolved.
Outdated
----

. To enable the migration, set an annotation on the Cluster Network Operator configuration object by entering the following command:
Expand All @@ -43,10 +43,10 @@ $ oc patch Network.config.openshift.io cluster \
--type='merge' --patch '{ "spec": { "networkType": "OVNKubernetes" } }'
----

. To confirm the migration disabled the OpenShift SDN default CNI network provider, enter the following command. It might take several moments for all the OpenShift SDN Pods to stop.
. To confirm the migration disabled the OpenShift SDN default CNI network provider and removed all OpenShift SDN Pods, enter the following command. It might take several moments for all the OpenShift SDN Pods to stop.
+
----
$ oc get pod -n openshift-sdn --watch
$ watch oc get pod -n openshift-sdn

@jboxman jboxman Aug 5, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dlbewley, what makes this preferable than --watch?

@dlbewley dlbewley Aug 5, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The condition the user wants to see is that all the pods are gone. Using --watch simply emits a stream of changes . It is much more obvious when the pods are gone with watch <cmd>, particularly if there are many pods (nodes).

If watch can be assumed to be broadly available I think the output is much more clear.

----

. To complete the migration, reboot each node in your cluster. For example, you could use a bash script similar to the following. The script assumes that you can connect to each host by using `ssh` and that you have configured `sudo` to not prompt for a password.
Expand Down
4 changes: 2 additions & 2 deletions modules/nw-ovn-kubernetes-rollback.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,10 @@ $ oc patch Network.config.openshift.io cluster \
$ oc edit Network.config.openshift.io cluster
----

. To confirm that the migration disabled the OVN-Kubernetes default CNI network provider, enter the following command. It might take several moments for all the OVN-Kubernetes Pods to stop.
. To confirm that the migration disabled the OVN-Kubernetes default CNI network provider and removed all the OVN-Kubernetes pods, enter the following command. It might take several moments for all the OVN-Kubernetes Pods to stop.

@codyhoag codyhoag Aug 6, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/pods/Pods

+
----
$ oc get pod -n openshift-ovn-kubernetes --watch
$ watch oc get pod -n openshift-ovn-kubernetes
----

. To complete the rollback, reboot each node in your cluster. For example, you could use a bash script similar to the following. The script assumes that you can connect to each host by using `ssh` and that you have configured `sudo` to not prompt for a password.
Expand Down