openshift-sdn to ovn-kubernetes migration testing feedback #24445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitely state success of no lingering openshift-sdn pods Use watch command rather than the oc --watch arg, which offers no indication of completion
openshift-ci-robot
added
the
size/S
Contributor
|
@dlbewley thanks, I'll take a look! |
dlbewley
changed the title
Contributor
Author
|
if i had a nickel for every time i've mistyped kubernetes..., i'd be less embarrased |
jboxman
reviewed
Aug 5, 2020
| + | ||
| ---- | ||
| $ oc get pod -n openshift-sdn --watch | ||
| $ watch oc get pod -n openshift-sdn |
Contributor
There was a problem hiding this comment.
@dlbewley, what makes this preferable than --watch?
Contributor
Author
There was a problem hiding this comment.
The condition the user wants to see is that all the pods are gone. Using --watch simply emits a stream of changes . It is much more obvious when the pods are gone with watch <cmd>, particularly if there are many pods (nodes).
If watch can be assumed to be broadly available I think the output is much more clear.
Contributor
|
Hi @huiran0826, Do these updates make sense? Thanks! |
|
lgtm |
jboxman
added
the
peer-review-needed
codyhoag
reviewed
Aug 6, 2020
Contributor
codyhoag
left a comment
codyhoag
left a comment
There was a problem hiding this comment.
Two small suggestions. Otherwise, LGTM!
| ---- | ||
|
|
||
| . To confirm that the migration disabled the OVN-Kubernetes default CNI network provider, enter the following command. It might take several moments for all the OVN-Kubernetes Pods to stop. | ||
| . To confirm that the migration disabled the OVN-Kubernetes default CNI network provider and removed all the OVN-Kubernetes pods, enter the following command. It might take several moments for all the OVN-Kubernetes Pods to stop. |
codyhoag
added
peer-review-done
Contributor
|
@dlbewley, if you can fix the two issues above we're good to go with this. Thanks! |
Contributor
|
@dlbewley, squashed and merged, thanks! |
jboxman
pushed a commit
to jboxman-rh/openshift-docs
that referenced
this pull request
Aug 17, 2020
…#24445) Update procedure for OVN-Kubernetes migration Explicitly state success of no lingering openshift-sdn pods Use watch command rather than the oc --watch arg, which offers no indication of completion Co-authored-by: Vagner Farias <vfarias@redhat.com>
jboxman
pushed a commit
to jboxman-rh/openshift-docs
that referenced
this pull request
Aug 17, 2020
…#24445) Update procedure for OVN-Kubernetes migration Explicitly state success of no lingering openshift-sdn pods Use watch command rather than the oc --watch arg, which offers no indication of completion Co-authored-by: Vagner Farias <vfarias@redhat.com>
jboxman
added a commit
that referenced
this pull request
Aug 17, 2020
…24832) Update procedure for OVN-Kubernetes migration Explicitly state success of no lingering openshift-sdn pods Use watch command rather than the oc --watch arg, which offers no indication of completion Co-authored-by: Dale Bewley <dale@bewley.net> Co-authored-by: Vagner Farias <vfarias@redhat.com>
jboxman
added a commit
that referenced
this pull request
Aug 17, 2020
[enterprise-4.6] openshift-sdn to ovn-kubernetes migration testing feedback (#24445)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested updates for openshift-sdn to ovn-kubernetes migration docs.