-
Notifications
You must be signed in to change notification settings - Fork 1.9k
CNV-3924 Feature Support Storage Matrix #23791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The preview will be available shortly at: |
|
@nellyc Please review the "VM import" column. Update: Nelly has approved the VM import column. |
modules/virt-supported-features-for-virtual-storage-matrix.adoc
Outdated
Show resolved
Hide resolved
virt/virtual_machines/virtual_disks/virt-supported-features-for-virtual-storage.adoc
Outdated
Show resolved
Hide resolved
|
I am wondering if 'supported' is a good word to use in the table, |
|
@nellyc I share your sentiment. "Supported" may misleading the reader to understand that Red Hat would support any CSI driver, while it is the CSI vendor that should do it. I think that "acceptable" or simply the tick mark would be better. |
@dankenigsberg and @nellyc would you be fine with either YES for Supported and NO for Not Supported? We try to stay away from graphics in tables. The other alternative I can think of is using "X" and "O" and then defining that in the table key. I pinged @aglitke and he is fine with YES and NO, he likes it. |
|
Im fine with Yes/No |
modules/virt-supported-features-for-virtual-storage-matrix.adoc
Outdated
Show resolved
Hide resolved
modules/virt-supported-features-for-virtual-storage-matrix.adoc
Outdated
Show resolved
Hide resolved
modules/virt-supported-features-for-virtual-storage-matrix.adoc
Outdated
Show resolved
Hide resolved
modules/virt-supported-features-for-virtual-storage-matrix.adoc
Outdated
Show resolved
Hide resolved
fabiand
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some things still need calrification
@fabiand Please review the latest comments and suggest clarifications if still needed. I am hoping to get this into peer review as soon as possible since this is our last week before release. Thanks, Bob |
Changed "Supported" to "Yes" and "Not Supported" to "No". |
f3aadd2 to
5f4579d
Compare
|
lgtm |
|
I think my only problem is with the vm import now |
c648e7e to
2e84f5c
Compare
adellape
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting footnote style changes in the table, but otherwise LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per discussion, let's update the table footnotes per https://github.com/openshift/openshift-docs/blob/master/contributing_to_docs/doc_guidelines.adoc#alternative-footnote-styling-in-tables.
adellape
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
|
/cherrypick enterprise-4.5 |
|
/cherrypick enterprise-4.6 |
|
@adellape: new pull request created: #24174 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@adellape: new pull request created: #24175 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR replaces #22638
Label enterprise-4.5 enterprise-4.6
Tagging @adellape for peer review.
All comments in previous PR have been acted upon and content is ready for final review.
See http://file.bos.redhat.com/bgaydos/072020/virt/virtual_machines/virtual_disks/virt-features-for-storage.html for test build.
Thanks,
Bob