-
Notifications
You must be signed in to change notification settings - Fork 1.9k
CNV-3924 Feature Support Storage Matrix Assembly and Module #22638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The preview will be available shortly at: |
|
@aglitke is best to check the table, but the way of presentation looks good. |
c32edf3 to
c49f616
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't yet make use of CSI cloning and storage-assisted cloning is currently done by way of CSI snapshots so we can compress (c) and (d) into one footnote to be used interchangeably. In the future, it will be possible to clone if the storage supports either CSI cloning or CSI snapshots.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Condensed (c) and (d) into:
(c) Storage provider must support CSI cloning via CSI snapshots
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Virtual machine snapshots are not supported in 2.4 so this column should not yet appear in the table.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replacing Virtual Machine Snapshots column with column added by @apinnick in comment below.
| |Supported | ||
| |Supported | ||
|
|
||
| |{VirtProductName} hostpath provisioner |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bgaydosrh Should {product-title} and {VirtProductName} have definite names, or they are various depends on what users have?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @qwang1 - yes, we use variables for the product names, so in case those names change the doc will always have the most current names.
Those names should appear correctly in the next test build.
|
@bgaydosrh Here's the update from our conversation on Slack. Please add another column called "VM import". All storage is "Supported" except "hostpath provisioner", which is "Not supported". This for RHV import to CNV storage support. |
Completed. |
|
Replaced by #23791 |
This module and assembly addresses https://issues.redhat.com/browse/CNV-3924 as well as https://issues.redhat.com/browse/CNV-4295. I will obsolete CNV-4295 if the matrix created in this PR meets requirements of CNV-4295.
Label Peer review needed and enterprise-4.5.
Code review requested from @aglitke and @fabiand
QE review requested from @qwang1
Test Build: http://file.bos.redhat.com/bgaydos/060320_2/virt/virtual_machines/virtual_disks/virt-supported-features-for-virtual-storage.html
Original table graphic from @aglitke attached:
Bob