Bug 1804083: Explains requirements for deploying RHEL compute node #22392
Conversation
openshift-ci-robot
added
bugzilla/severity-medium
|
@adduarte: This pull request references Bugzilla bug 1804083, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
openshift-ci-robot
added
the
size/XS
|
/assign @maxwelldb |
maxwelldb
changed the title
|
@pierreprinetti @adduarte @mandre Is this targeting 4.4 or 4.4+? |
|
It's targeting 4.4+ but isn't a blocker for 4.5. |
maxwelldb
left a comment
maxwelldb
left a comment
There was a problem hiding this comment.
@mandre What do you think about leaving the general part of this as is:
Each system should be able to access the cluster's API
endpoints using a DNS resolvable hostname. Any network security access control in place should allow the system access to the cluster's API service endpoints. This maybe tested by using a tool like curl,curl --insecure <URL>:<port>, and verifying it does not time out.
But moving the OSP-specific note to the ShiftStack installation docs? Otherwise, I think it looks out of place if we don't describe similar measures for all of the other platforms.
I can restructure if you agree.
|
/lgtm |
|
@adduarte: you cannot LGTM your own PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Made requested change. Left specific statement of network security to address original root cause |
maxwelldb
left a comment
maxwelldb
left a comment
There was a problem hiding this comment.
Small suggestion, plus deleting duplicate spaces.
ahardin-rh
added
peer-review-done
|
Just one peer review comment from me. Otherwise, looks great! |
|
@ahardin-rh TY! |
|
@adduarte Make that one last change, and then squash this PR into one commit. Then, I can merge it. 👍 |
Misconfiguratoin of DNS and netwrok control access will cause the addition of rhel compute node to fail. DNS configuration and network control access are under the control of the user and their state can not be predicted. In order to prevent the failures, it falls on the users shoulders to verify that DNS and control access are correctly configured to allow the needed access. The access maybe easily tested prior to installation.
adduarte
force-pushed
the
bug_1804083
branch
from
f185b4c to
0745423
Compare
|
@maxwelldb there you go (I hope) I think I got everything and squashed to one commit. |
|
@adduarte Looking good! Just one fix for a problem that the last edit introduced: "DNS resolvable" -> ""DNS-resolvable" I tried to add the commit myself, but I don't have rights to shiftstack/openshift-docs. Promise--that's the last thing! |
You should now have received an invite. |
|
/lgtm |
|
@adduarte: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged:
These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Bugzilla bug 1804083 has not been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick enterprise-4.4 |
|
/cherry-pick enterprise-4.5 |
|
/cherry-pick enterprise-4.6 |
|
@maxwelldb: new pull request created: #25582 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@maxwelldb: new pull request created: #25583 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@maxwelldb: new pull request created: #25584 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@adduarte Merged into master and relevant release branches. |
7 participants
Misconfiguratoin of DNS and netwrok control access will cause the
addition of rhel compute node to fail.
DNS configuration and network control access are under the control of the user
and their state can not be predicted.
In order to prevent the failures, it falls on the users shoulders to verify
that DNS and control access are correctly configured to allow the needed access.
The access maybe easily tested prior to installation.