-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Describe configuring an internal load balancer for cloud #16963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe configuring an internal load balancer for cloud #16963
Conversation
|
The preview will be available shortly at: |
|
@Miciah, thanks. This was more of a point of a departure than a finished PR. I have a few other items to complete before I can revisit this and finalize it for a review. |
|
@Miciah, I'm not yet familiar with the Ingress Operator or controllers. What does "the IngressController is published by a public cloud load balancer by default" mean? What does it mean to get published? Thanks. |
It means "made available" or "exposed"; "published" doesn't have a technical meaning beyond that one that we give it in the API definition (https://godoc.org/github.com/openshift/api/operator/v1#EndpointPublishingStrategy). To rephrase the statement that you quoted, the Ingress Operator will create a cloud load balancer through which clients can connect to the IngressController unless the IngressController specifies a different endpoint publishing strategy. |
6645d92 to
3f5d209
Compare
lamek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small question, otherwise LGTM.
3f5d209 to
b7e1682
Compare
|
@Miciah, I've updated this; How does it look? Thanks! |
Miciah
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggested one minor correction, but otherwise looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jboxman, this restriction came up on the Group G arch call:
4.2.0 warning on switching ingress to Internal can cause all worker nodes to lose internet connectivity. The only way to prevent that would be to have at least one public k8s service even if it doesn’t do anything
I think that we might need a step to confirm that you have such a service.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm surprised to learn there is such a restriction, and it seems like a very serious defect. Is there an associated Bugzilla report?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abhinavdahiya, was there a bug for the need to have at least one public k8s service if you switch the ingress controller to private?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be noted that the restriction applies specifically to Azure, not to other cloud platforms. (It has already been noted in the Group G arch call, but I'm repeating it here for the benefit of anyone who learns of the issue from seeing this thread.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to talk with @Miciah and @abhinavdahiya and @wking about how we solve this transparently. I think we should treat the issue as a blocker bug that we'll solve before release and remove the note here entirely.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds like the installer already sets up egress for private clusters in 4.3 by installing a public LB, so there's nothing to note here after all?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the installer only sets up egress by creating a dummy public standard load balancer, when users request Internal clusters.
so for public cluster users, that want to make their ingress private as Day-2, there should be warning that, all nodes of the cluster will loose egress to internet in case there is no public LB pointing to those nodes...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abhinavdahiya, is that for any public cloud provider user, or just for Azure? As I'm still trying to internalize this, my first pass at this is simply the following:
If your cloud provider is Azure, you must have at least one public load balancer that points to your nodes.
If you do not, all of your nodes will lose egress connectivity to the Internet.
But if I include this as part of the procedure, is there a way to confirm if there is at least one public load-balancer point to all nodes? Doesn't having a public load-balancer defeat the purpose of private ingress?
Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@kalexand-rh, does the work you're doing supersede this PR? If so, should I close it or finalize it? Thanks! |
|
@jboxman, please finalize it. I'll incorporate the content in the change that I'm working on. |
b7e1682 to
e31cfd4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.spec.domain is required unless we're talking about the default resource (which can omit .spec.domain and claim the default domain).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ironcladlou I'm helping out to get this PR merged and just want to verify - this is the only update this PR needs? Thanks!
(I'll also likely have follow-up questions related to "User defined IngressControllers at installation".)
e31cfd4 to
976c6f6
Compare
|
@jboxman - just in case you see this, I'm going to grab this PR first thing in the morning and get it merged. Thanks! |
Would it be clearer to represent these separately? The procedure for Configuring an Ingress Controller to use an internal load balancer is similar to what's already here, except we can remove all the notes about the default ingresscontroller, as we're talking about creating additional ingress controllers that live alongside the default. The procedure for configure the |
|
@bmcelvee, thanks! It's been floating in the ether for a while now. I believe there's similar content that is trapped in our release notes for 4.2 that has been requested to come out. |
|
Merging this PR with the |
|
/cherrypick enterprise-4.2 |
|
@bmcelvee: new pull request created: #18760 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick enterprise-4.3 |
|
@bmcelvee: new pull request created: #18761 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Link to follow-up PR: #18764. |
Describe how to configure the Ingress Controller to use an internal load balancer on cloud providers.