Skip to content

Conversation

@ahardin-rh
Copy link
Contributor

@ahardin-rh ahardin-rh commented Aug 27, 2019

@ahardin-rh ahardin-rh added this to the Future Release milestone Aug 27, 2019
@ahardin-rh ahardin-rh self-assigned this Aug 27, 2019
@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 27, 2019
@ahardin-rh ahardin-rh force-pushed the OCP-4-2-release-notes branch from 74765d7 to 77c1d2b Compare August 30, 2019 21:55
@openshift-ci-robot openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 30, 2019
@ahardin-rh ahardin-rh force-pushed the OCP-4-2-release-notes branch from 77c1d2b to 06cab55 Compare September 6, 2019 20:02
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4.2 introduces both disconnected installs and proxy supported installs

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

though this was tech preview in 4.2.. cc @knewcomerRH

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not even tech preview. Please remove any reference to FIPS mode. Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deprecated in 4.2? cc @jwforres (I don't know where this landed)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(same for the 2 brokers below)

@huffmanca
Copy link
Contributor

huffmanca commented Sep 9, 2019

Storage changes:

  • In the 4.1 release notes EFS was incorrectly marked as general availability. This is being included as a technology preview feature in 4.2.
  • In the 4.1 release notes volume Snapshots were incorrectly marked as being included as tech preview. They are not included in OCP 4.x.
  • Persistent volume snapshots are being deprecated in OCP 4.2.
  • Persistent volumes using the Local Storage Operator is being introduced in OCP 4.2.
  • CSI is moving to GA from Tech Preview.

@knewcomerRH
Copy link

knewcomerRH commented Sep 9, 2019 via email

@ahardin-rh ahardin-rh force-pushed the OCP-4-2-release-notes branch from 06cab55 to 8e2cd3e Compare September 16, 2019 19:07
@ahardin-rh ahardin-rh force-pushed the OCP-4-2-release-notes branch 4 times, most recently from f46a8b5 to c22e4f2 Compare September 20, 2019 21:06
@openshift-docs-preview-bot

The preview will be available shortly at:

@ahardin-rh ahardin-rh force-pushed the OCP-4-2-release-notes branch from c22e4f2 to 3e50d93 Compare September 23, 2019 22:37
Copy link
Contributor

@vikram-redhat vikram-redhat Sep 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{product-version} here and at other places.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add header formatting here - please and thank you!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this supposed to be a header?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested replacement for this section:

When creating an IngressController on cloud platforms, the IngressController is
published by a public cloud load balancer by default.

Users can now publish IngressControllers with internal cloud load balancers. For example:

apiVersion: operator.openshift.io/v1
kind: IngressController
metadata:
  namespace: openshift-ingress-operator
  name: internal
spec:
  endpointPublishingStrategy:
    type: LoadBalancerService
    loadBalancer:
      scope: Internal

See the link:https://kubernetes.io/docs/concepts/services-networking/#internal-load-balancer.[Kubernetes Services documentation]
for implementation details.

Note that once set, .spec.endpointPublishingStrategy.loadBalancer.scope cannot
be changed. To change the scope, delete and recreate the IngressController.

The default IngressController can be made internal by deleting and recreating
it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @openshift/sig-network-edge

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is release notes, I think we should move the details and example to product document (a new topic in https://docs.openshift.com/container-platform/4.2/networking/ingress-operator.html), and here just provide the link to it like:
See xref:.. for more information.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I've created #16963 for this content.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zvonkok can you review the above statements for GPU enablement?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zvonkok @ahardin-rh should SRO documentation be included in product docs? It is a community operator at this point, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ashishkamra I will pull it out for now. Thanks!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iSCSi -> iSCSI

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the RHHI.next section may need to be removed after the recent announcements

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gabemontero do we have a note elsewhere about the restrictions on builds in disconnected envs? (sounds like the restriction is "they won't work" at this point since there is no way for the user to get the creds to be correct for the mirror)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nm, found the note/limitation at the bottom.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is moved to the dev perspective, right @spadgett? should probably say where it was moved to.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's moved to the Developer perspective.

Developer -> Add+ -> From Catalog

@ahardin-rh ahardin-rh force-pushed the OCP-4-2-release-notes branch 2 times, most recently from c3791ff to 72f5e5e Compare September 26, 2019 18:28
@ahardin-rh ahardin-rh changed the title [WIP]Added 4.2 release notes Added 4.2 release notes Sep 26, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 26, 2019
@ahardin-rh ahardin-rh force-pushed the OCP-4-2-release-notes branch 2 times, most recently from 84a9a84 to 4b529d5 Compare September 27, 2019 17:22
@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 27, 2019
@adellape adellape force-pushed the OCP-4-2-release-notes branch from c6dea59 to cf481b2 Compare September 27, 2019 19:19
@ahardin-rh ahardin-rh force-pushed the OCP-4-2-release-notes branch from 656efe1 to 9927ce2 Compare September 27, 2019 20:02

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we need to add
brokertemplateinstance.template.openshift.io

This is only added when template-service-broker is installed.
@bparees can you ack that this is correct and that we should add it here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually it looks like brokertemplateinstance is served out of the openshift apiserver, so i guess it'll still be present (but utterly useless w/ no TSB).

https://github.com/openshift/openshift-apiserver/tree/master/pkg/template/apiserver/registry/brokertemplateinstance

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove this type in 4.4 as well?

@ahardin-rh ahardin-rh force-pushed the OCP-4-2-release-notes branch from 9927ce2 to 9daed32 Compare October 1, 2019 17:34
@ahardin-rh
Copy link
Contributor Author

I believe I addressed all feedback to date; I am merging this now and we can continue to iterate in separate PRs.

@ahardin-rh ahardin-rh merged commit b824d0c into openshift:master Oct 1, 2019
@ahardin-rh
Copy link
Contributor Author

/cherrypick enterprise-4.2

@openshift-cherrypick-robot

@ahardin-rh: new pull request created: #16972

Details

In response to this:

/cherrypick enterprise-4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sunilcio
Copy link

@ahardin-rh new edit suggestion in #17174

jboxman added a commit to jboxman-rh/openshift-docs that referenced this pull request Nov 20, 2019
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/openshift-docs that referenced this pull request Dec 19, 2019
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/openshift-docs that referenced this pull request Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.2 size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.