MULTIARCH-4558: Set default for imagestreamImportMode based on observed config changes in the image config #443
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@Prashanth684: This pull request references MULTIARCH-4558 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Prashanth684
force-pushed
the
importmode-apiserver
branch
5 times, most recently
from
aebb812 to
5d70b8d
Compare
Prashanth684
force-pushed
the
importmode-apiserver
branch
2 times, most recently
from
2b98fcf to
fc288b2
Compare
|
@Prashanth684: This pull request references MULTIARCH-4558 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
dinhxuanvu
left a comment
dinhxuanvu
left a comment
There was a problem hiding this comment.
Looking good.
The verify job will fail due to some changes on code-generator that breaks some scripts. I'm working on resolving that issue.
dinhxuanvu
left a comment
dinhxuanvu
left a comment
There was a problem hiding this comment.
Overall, looks good.
Can you squash the all changes on go.mod and vendor into 1 commit and let the plugin code change in a separate commit?
The verify test will continue to fail until we fix the code-gen changes on the scripts. However, other tests should pass.
Prashanth684
force-pushed
the
importmode-apiserver
branch
from
ff3d53c to
37dea86
Compare
Prashanth684
force-pushed
the
importmode-apiserver
branch
2 times, most recently
from
99b7cc7 to
482c932
Compare
|
waiting for #441. |
openshift-merge-robot
added
the
needs-rebase
Prashanth684
force-pushed
the
importmode-apiserver
branch
from
482c932 to
3c31796
Compare
openshift-merge-robot
removed
the
needs-rebase
|
@dinhxuanvu @tkashem rebased after #441 and bumped api version. Should be good now. |
Prashanth684
force-pushed
the
importmode-apiserver
branch
from
3c31796 to
c8310b1
Compare
…ed config changes in the image config As per openshift/enhancements#1605, there was a new field introduced in the image config spec and status which reflects the global value to be set for imagestream import mode which is behind a featuregate. This PR reads the observed config, checks if the importmode string is present and uses it as the default when creating imagestreams.
|
@tkashem For the final review/approval. |
|
usually defaults are hardcoded values, but this one is more dynamic, and so needs this convoluted way, approving based on David's suggestion here: https://redhat-internal.slack.com/archives/C013VBYBJQH/p1711628286172049?thread_ts=1711476458.959689&cid=C013VBYBJQH Maybe an admission plugin can help here (or CEL when mutating policy is available maybe?), something worth looking into before we promote it from TechPreview /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dinhxuanvu, Prashanth684, tkashem The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Prashanth684
added
the
acknowledge-critical-fixes-only
|
@Prashanth684: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[ART PR BUILD NOTIFIER] Distgit: ose-openshift-apiserver |
6 participants
As per openshift/enhancements#1605, there was a
new field introduced in the image config spec and status which reflects
the global value to be set for imagestream import mode which is behind a
featuregate. This PR reads the observed config, checks if the importmode
string is present and uses it as the default when creating imagestreams.
API changes: openshift/api#1928
cluster-openshift-apiserver-operator changes: openshift/cluster-openshift-apiserver-operator#582
image-registry-operator changes: openshift/cluster-image-registry-operator#109