MULTIARCH-4971: Sync ImageStreamImportMode setting in the image config status#1090
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@Prashanth684: This pull request references MULTIARCH-4552 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.18.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Prashanth684
changed the title
Prashanth684
force-pushed
the
importmode-imagestream
branch
from
8f18bcd to
3bff23f
Compare
As per openshift/enhancements#1605, there was a new field introduced in the image config spec and status which reflects the global value to be set for imagestream import mode which is behind a featuregate. This PR sets the status field in the image config based on the spec setting so it can be synced by the apiserver's observedconfig to set the import mode for imagestreams.
|
/test e2e-aws-operator |
|
@Prashanth684: This pull request references MULTIARCH-4552 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.18.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Prashanth684
force-pushed
the
importmode-imagestream
branch
from
3bff23f to
59fb3ba
Compare
|
/retest-required |
|
flaky tests.. |
|
still flaking 🤔 The changes look pretty straight forward. I assume this needs to be tested (and merged) in conjunction with openshift/cluster-openshift-apiserver-operator#582 and openshift/openshift-apiserver#443? |
correct. In addition to that it is all behind a featuregate. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flavianmissi, Prashanth684 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Prashanth684
changed the title
|
@Prashanth684: This pull request references MULTIARCH-4971 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
What's the docs plan here, @Prashanth684? Do we want to involve image registry docs or is this something your team's docs will take care of? Asking because this PR requires docs approval for merging. Similar question applies to PX. |
We have a story targeting docs - https://issues.redhat.com/browse/MULTIARCH-4560 . @sr1kar99 is the multi-arch docs contact and will be working on this - he will work with the Image registry's docs contact if necessary. @sr1kar99 could you add the docs-approved label to this PR please? |
|
tagging @sferich888 for the px-approved label |
|
As discussed in slack, did a single-arch test, no critical issue found. |
openshift-ci
bot
added
the
qe-approved
|
@Prashanth684: This pull request references MULTIARCH-4971 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/label docs-approved |
openshift-ci
bot
added
the
docs-approved
|
/label px-approved |
openshift-ci
bot
added
the
px-approved
Prashanth684
added
the
acknowledge-critical-fixes-only
1 similar comment
|
/test e2e-hypershift |
|
/test e2e-hypershift-conformance |
|
@Prashanth684: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[ART PR BUILD NOTIFIER] Distgit: ose-cluster-image-registry-operator |
7 participants
As per openshift/enhancements#1605, there was a
new field introduced in the image config spec and status which reflects
the global value to be set for imagestream import mode which is behind a
featuregate. This PR sets the status field in the image config based on
the spec setting so it can be synced by the apiserver's observedconfig
to set the import mode for imagestreams.
xref: openshift/cluster-openshift-apiserver-operator#582 , openshift/openshift-apiserver#443