Skip to content

Forward port kube proxy role and run it only once for Calico installs#9872

Closed
mgleung wants to merge 2 commits intoopenshift:masterfrom
mgleung:calico-kube-proxy-multi-master-master
Closed

Forward port kube proxy role and run it only once for Calico installs#9872
mgleung wants to merge 2 commits intoopenshift:masterfrom
mgleung:calico-kube-proxy-multi-master-master

Conversation

@mgleung
Copy link
Contributor

@mgleung mgleung commented Aug 31, 2018

Forward port of #9621 which adds a kube_proxy_and_dns role

Ensure that the kube_proxy_and_dns role dependency is run only once for Calico. This fixes errors that would occur in a multiple master scenario.

This is also a forward port of #9871

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mgleung
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: vrutkovs

If they are not already assigned, you can assign the PR to them by writing /assign @vrutkovs in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 31, 2018
@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 31, 2018
@openshift-ci-robot
Copy link

Hi @mgleung. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mgleung mgleung changed the title Calico kube proxy multi master master Forward port kube proxy role and run it only once for Calico installs Aug 31, 2018
@papr-bot
Copy link

Can one of the admins verify this patch?
I understand the following commands:

  • bot, add author to whitelist
  • bot, test pull request
  • bot, test pull request once

@vrutkovs
Copy link
Contributor

vrutkovs commented Sep 3, 2018

I'd prefer a direct cherrypick - see #9878, it would be easier to maintain

@sdodson
Copy link
Member

sdodson commented Sep 4, 2018

#9878 merged closing this.

@sdodson sdodson closed this Sep 4, 2018
@mgleung mgleung deleted the calico-kube-proxy-multi-master-master branch September 10, 2018 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants