Skip to content

Run the kube-proxy once per cluster for Calico#9871

Merged
openshift-merge-robot merged 1 commit intoopenshift:release-3.10from
mgleung:calico-kube-proxy-multi-master
Sep 13, 2018
Merged

Run the kube-proxy once per cluster for Calico#9871
openshift-merge-robot merged 1 commit intoopenshift:release-3.10from
mgleung:calico-kube-proxy-multi-master

Conversation

@mgleung
Copy link
Contributor

@mgleung mgleung commented Aug 31, 2018

Ensure that the kube_proxy_and_dns role dependency is run only once for Calico. This fixes errors that would occur in a multiple master scenario.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 31, 2018
@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 31, 2018
@papr-bot
Copy link

Can one of the admins verify this patch?
I understand the following commands:

  • bot, add author to whitelist
  • bot, test pull request
  • bot, test pull request once

@mgleung
Copy link
Contributor Author

mgleung commented Sep 12, 2018

@vrutkovs now that #9984 has been merged, is this one also good to go?

@vrutkovs
Copy link
Contributor

/ok-to-test

@openshift-ci-robot openshift-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 13, 2018
@vrutkovs
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mgleung, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2018
@openshift-merge-robot openshift-merge-robot merged commit 1aae920 into openshift:release-3.10 Sep 13, 2018
@mgleung mgleung deleted the calico-kube-proxy-multi-master branch September 26, 2018 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants