apply the container_runtime for calico

[dmmcquay]

Add the correct container_runtime to fix calico build.

/cc @ozdanborne

Signed-off-by: derek mcquay [email protected]

[papr-bot]

Can one of the admins verify this patch?
I understand the following commands:

• bot, add author to whitelist
• bot, test pull request
• bot, test pull request once

[vrutkovs]

/ok-to-test

[vrutkovs]

That doesn't seem to be fixing the issue with setting up calico here though.

Inventory:

openshift_use_calico: true
openshift_use_openshift_sdn: false
os_sdn_network_plugin_name: 'cni'

The node is stuck in NotReady and calico-kube-controllers-5bdd9c79c4-4gvpt pod won't start: 0/1 nodes are available: 1 node(s) were not ready.

[dmmcquay]

@vrutkovs Are you seeing this in CI or are you testing locally? Was curious to see if I could debug it.

[vrutkovs]

@dmmcquay testing locally, I could be doing something wrong though. Does this PR solve all install issues in your setup?

[dmmcquay]

@vrutkovs there might be other issues :)

I am curious if that failing pod you mention has anything else in the logs that might help me understand what is happening. What if you ran a kubectl describe pod calico-kube-controllers-5bdd9c79c4-4gvpt -n kube-system, notice anything weird in the events section?

[vrutkovs]

Right, there's Error creating: pods "calico-kube-controllers-7ffbc994bf-" is forbidden: error looking up service account kube-system/calico-kube-controllers: serviceaccount "calico-kube-controllers" not found. Found a few more issues with it, created #9435 for that - lets move out there.

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dmmcquay, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [vrutkovs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ozdanborne]

Just to help with the paper trail, see this comment: #7592 (comment)

Seems #6297 added a new container_runtime role without adding it as Calico's dependencies.

The workaround is to update roles/calico/meta/main.yml, and add role: container_runtime as a dependency.

I would recommend instead of implementing that workaround, users try the updated self-hosted installation method for Calico, which is in latest master as well as the release-3.9 branch.