Skip to content

Implement container runtime role #6297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sdodson merged 1 commit into from
Dec 4, 2017
Merged

Implement container runtime role #6297

sdodson merged 1 commit into from
Dec 4, 2017

Conversation

@michaelgugino
Copy link
Contributor

@michaelgugino michaelgugino commented Nov 28, 2017

No description provided.

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 28, 2017
@michaelgugino
Copy link
Contributor Author

michaelgugino commented Nov 28, 2017

/test containerized

@michaelgugino
Copy link
Contributor Author

michaelgugino commented Nov 29, 2017

/test install

2 similar comments
@michaelgugino
Copy link
Contributor Author

michaelgugino commented Nov 29, 2017

/test install

@michaelgugino
Copy link
Contributor Author

michaelgugino commented Nov 29, 2017

/test install

@michaelgugino michaelgugino force-pushed the crt_role branch 2 times, most recently from e8c7e0c to 69cfdf0 Compare November 29, 2017 16:36
@michaelgugino michaelgugino changed the title [wip] Implement container runtime role Implement container runtime role Nov 29, 2017
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 29, 2017
@michaelgugino
Copy link
Contributor Author

michaelgugino commented Nov 29, 2017

/retest

@michaelgugino
Copy link
Contributor Author

michaelgugino commented Nov 29, 2017

Install has passed.... guess those were flakes.

@michaelgugino michaelgugino mentioned this pull request Nov 30, 2017
Merged
@sdodson
Copy link
Member

sdodson commented Nov 30, 2017

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2017
@michaelgugino
Copy link
Contributor Author

michaelgugino commented Nov 30, 2017

401 unauthorized flake from repo mirror :/

/retest

@michaelgugino
Copy link
Contributor Author

michaelgugino commented Dec 1, 2017

/test containerized

/test install

/test system-containers

@openshift-merge-robot openshift-merge-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2017
@michaelgugino michaelgugino reopened this Dec 1, 2017
@michaelgugino
Copy link
Contributor Author

michaelgugino commented Dec 1, 2017

/test install

2 similar comments
@michaelgugino
Copy link
Contributor Author

michaelgugino commented Dec 4, 2017

/test install

@michaelgugino
Copy link
Contributor Author

michaelgugino commented Dec 4, 2017

/test install

@michaelgugino
Copy link
Contributor Author

michaelgugino commented Dec 4, 2017

bot, retest this please

@sdodson
Copy link
Member

sdodson commented Dec 4, 2017

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2017
@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Dec 4, 2017

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 4, 2017

@michaelgugino: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/upgrade 5120f8e link /test upgrade
ci/openshift-jenkins/install 5120f8e link /test install

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sdodson
Copy link
Member

sdodson commented Dec 4, 2017

that's a flake

@sdodson sdodson merged commit 5a7b6be into openshift:master Dec 4, 2017
@ashcrow ashcrow mentioned this pull request Dec 5, 2017
Merged
@ozdanborne ozdanborne mentioned this pull request Apr 18, 2018
Closed
@ozdanborne ozdanborne mentioned this pull request Aug 7, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kwoodson kwoodson Awaiting requested review from kwoodson

@abutcher abutcher Awaiting requested review from abutcher

@sdodson sdodson Awaiting requested review from sdodson

@mtnbikenc mtnbikenc Awaiting requested review from mtnbikenc

Assignees

@sdodson sdodson

Labels

lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@michaelgugino @sdodson @openshift-merge-robot @openshift-ci-robot