Filter non-strings from the oc_adm_ca_server_cert hostnames parameter. #4197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the omit filter to be used in the hostnames parameter list which simplifies conditionally added hostnames.
ashcrow
approved these changes
May 15, 2017
abutcher
changed the title
|
aos-ci-test |
|
aos-ci-test |
|
Flake like thing from yesterday: |
|
@sdodson have you cleaned up stale vms lately? |
|
[merge] |
|
flake openshift/origin#13271 |
|
[merge] |
|
Evaluated for openshift ansible merge up to 75c752d |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_openshift_ansible/388/) (Base Commit: 7d506ff) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the omit filter to be used in the hostnames parameter list
which simplifies conditionally added hostnames.
Note: I've added the additional import to
src/ansible/oc_adm_ca_server_cert.pyrather than the global/base imports file so that the new import only affects theoc_adm_ca_server_certmodule.