Improve configurability of registry and registry-console hosts #4181
Conversation
|
Can one of the admins verify this patch?
|
1 similar comment
|
Can one of the admins verify this patch?
|
|
@abutcher as per discussed -- to improve the use case around standalone registry. The SSL certificate bits are a bit more involved and I can't do it right now but it would definitely be something we'd need. |
| @@ -55,6 +55,7 @@ | |||
| - "{{ docker_registry_service_ip.results.clusterip }}" | |||
| - "{{ openshift_hosted_registry_name }}.default.svc" | |||
| - "{{ openshift_hosted_registry_name }}.default.svc.{{ openshift.common.dns_domain }}" | |||
| - "{{ openshift_hosted_registry_routehost | default(omit) }}" | |||
There was a problem hiding this comment.
omit fails in the negative case since we expect each item in this list to be a string. My proposed fix is to filter non-strings from the list, PR here #4197
Otherwise, the registry-console is always defaulted to registry-console-<namespace>-<host> and may not be customized by the deployer.
openshift_hosted_registry_routehost allows a deployer to customize the host for the docker-registry route.
Users can specify a custom hostname for the docker registry route. We need to have the certificate match that host if it is specified so that you can use docker commands against that host.
|
Rebased my PR on top of master with #4197 which merged. |
|
aos-ci-test |
|
If you wait a little bit, I'll rework this PR with SSL support for registry-console - it's a work in progress. |
|
@dmsimard copy that |
|
Osboleted by #4256 .. going to close this. |
This adds missing docs on the registry host route variable that can be specified to customize the host on the registry route.
Additionally, it adds the ability to customize the registry-console route host which allows to get something other than the provided default.