Skip to content

Add required dirs for crio 1.14.4 #11698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jun 28, 2019
Merged

Add required dirs for crio 1.14.4 #11698

openshift-merge-robot merged 1 commit into from
Jun 28, 2019

Conversation

@mtnbikenc
Copy link
Member

@mtnbikenc mtnbikenc commented Jun 14, 2019

No description provided.

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 14, 2019
@patrickdillon
Copy link
Contributor

patrickdillon commented Jun 15, 2019

/retest

@patrickdillon
Copy link
Contributor

patrickdillon commented Jun 15, 2019

2019/06/14 19:33:05 Container scaleup in pod e2e-aws-scaleup-rhel7 completed successfully Waiting for scaleup to complete...completed!
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 15, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 15, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mtnbikenc, patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [mtnbikenc,patrickdillon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link

openshift-bot commented Jun 15, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link

openshift-bot commented Jun 16, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jun 16, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jun 16, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jun 16, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jun 16, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@patrickdillon
Copy link
Contributor

patrickdillon commented Jun 16, 2019

/hold
Stop tests until we can analyze failures/flakes. Anyone should feel free to cancel this hold.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 16, 2019
@vrutkovs vrutkovs mentioned this pull request Jun 18, 2019
Merged
@vrutkovs
Copy link
Contributor

vrutkovs commented Jun 18, 2019

Contacted @haircommander and @vrothberg to have a look at the failing kubectl test

@vrutkovs vrutkovs mentioned this pull request Jun 18, 2019
Closed
@vrutkovs
Copy link
Contributor

vrutkovs commented Jun 24, 2019

/retest

1 similar comment
@vrutkovs
Copy link
Contributor

vrutkovs commented Jun 27, 2019

/retest

@mtnbikenc
Copy link
Member Author

mtnbikenc commented Jun 27, 2019

This PR should not be needed with crio 1.14.5.
/hold

@mtnbikenc
Copy link
Member Author

mtnbikenc commented Jun 27, 2019

Moving forward with this PR to unblock other PRs. Will continue to work the crio issues in https://bugzilla.redhat.com/show_bug.cgi?id=1723295. A follow-up PR will be opened to remove this code.
/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 27, 2019
@mtnbikenc
Copy link
Member Author

mtnbikenc commented Jun 27, 2019

/retest

Failing tests:

[Feature:Platform] Managed cluster should have no crashlooping pods in core namespaces over two minutes [Suite:openshift/conformance/parallel]
[sig-auth] ServiceAccounts should allow opting out of API token automount  [Conformance] [Suite:openshift/conformance/parallel/minimal] [Suite:k8s]
[sig-scheduling] SchedulerPriorities [Serial] Pod should be preferably scheduled to nodes pod can tolerate [Suite:openshift/conformance/serial] [Suite:k8s]

@openshift-bot
Copy link

openshift-bot commented Jun 27, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link

openshift-bot commented Jun 28, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link

openshift-bot commented Jun 28, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 1f1b175 into openshift:master Jun 28, 2019
@mtnbikenc mtnbikenc deleted the fix-crio-plugin-dir branch June 28, 2019 13:51
@mtnbikenc mtnbikenc mentioned this pull request Jul 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jstuever jstuever Awaiting requested review from jstuever

@vrutkovs vrutkovs Awaiting requested review from vrutkovs

Assignees

@patrickdillon patrickdillon

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mtnbikenc @patrickdillon @openshift-ci-robot @openshift-bot @vrutkovs @openshift-merge-robot